Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 12258044: cc: Add PictureLayerImpl::AsValue (Closed)

Created:
7 years, 10 months ago by enne (OOO)
Modified:
7 years, 10 months ago
Reviewers:
nduca
CC:
chromium-reviews, cc-bugs_chromium.org
Visibility:
Public.

Description

cc: Add PictureLayerImpl::AsValue This allows for information about contents scales and tilings to be recorded for the frame viewer. R=nduca@chromium.org BUG=176413 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182747

Patch Set 1 #

Total comments: 4

Patch Set 2 : Size as value #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -0 lines) Patch
M cc/layer_impl.h View 3 chunks +5 lines, -0 lines 0 comments Download
M cc/layer_impl.cc View 1 2 chunks +23 lines, -0 lines 0 comments Download
M cc/layer_tree_host_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M cc/layer_tree_impl.h View 2 chunks +2 lines, -0 lines 0 comments Download
M cc/layer_tree_impl.cc View 1 chunk +16 lines, -0 lines 0 comments Download
M cc/picture_layer_impl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M cc/picture_layer_impl.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M cc/picture_layer_tiling.h View 1 chunk +2 lines, -0 lines 0 comments Download
M cc/picture_layer_tiling.cc View 1 1 chunk +9 lines, -0 lines 0 comments Download
M cc/picture_layer_tiling_set.h View 1 chunk +2 lines, -0 lines 0 comments Download
M cc/picture_layer_tiling_set.cc View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
enne (OOO)
7 years, 10 months ago (2013-02-15 01:07:10 UTC) #1
nduca
lgtm minor nits https://codereview.chromium.org/12258044/diff/1/cc/layer_impl.cc File cc/layer_impl.cc (right): https://codereview.chromium.org/12258044/diff/1/cc/layer_impl.cc#newcode977 cc/layer_impl.cc:977: dict->SetInteger("layer_height", bounds().width()); bounds_size? MathUtils should have ...
7 years, 10 months ago (2013-02-15 01:10:24 UTC) #2
enne (OOO)
https://codereview.chromium.org/12258044/diff/1/cc/layer_impl.cc File cc/layer_impl.cc (right): https://codereview.chromium.org/12258044/diff/1/cc/layer_impl.cc#newcode977 cc/layer_impl.cc:977: dict->SetInteger("layer_height", bounds().width()); On 2013/02/15 01:10:24, nduca wrote: > bounds_size? ...
7 years, 10 months ago (2013-02-15 01:14:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/12258044/5001
7 years, 10 months ago (2013-02-15 01:14:35 UTC) #4
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=11204
7 years, 10 months ago (2013-02-15 14:18:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/12258044/5001
7 years, 10 months ago (2013-02-15 17:16:26 UTC) #6
commit-bot: I haz the power
7 years, 10 months ago (2013-02-15 17:36:45 UTC) #7
Message was sent while issue was closed.
Change committed as 182747

Powered by Google App Engine
This is Rietveld 408576698