Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1887)

Unified Diff: chrome/browser/renderer_host/web_cache_manager_unittest.cc

Issue 12258039: enable -Wstring-conversion when compiling with clang (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: enable on mac, better fix in web_data_service Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/common.gypi ('k') | chrome/browser/webdata/web_data_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/renderer_host/web_cache_manager_unittest.cc
diff --git a/chrome/browser/renderer_host/web_cache_manager_unittest.cc b/chrome/browser/renderer_host/web_cache_manager_unittest.cc
index 4d82178785d6f5a85184a4a0ad3ecca206dd76d7..80f1716e6118c56a5ce77640a6c2ec8487e58560 100644
--- a/chrome/browser/renderer_host/web_cache_manager_unittest.cc
+++ b/chrome/browser/renderer_host/web_cache_manager_unittest.cc
@@ -256,7 +256,7 @@ TEST_F(WebCacheManagerTest, AttemptTacticTest) {
else if (iter->first == kRendererID2)
EXPECT_LE(kStats2.liveSize, iter->second);
else
- EXPECT_FALSE("Unexpected entry in strategy");
+ ADD_FAILURE(); // Unexpected entry in strategy.
++iter;
}
@@ -296,7 +296,7 @@ TEST_F(WebCacheManagerTest, AddToStrategyTest) {
else if (iter->first == kRendererID2)
EXPECT_LE(kStats2.liveSize + kStats2.deadSize, iter->second);
else
- EXPECT_FALSE("Unexpected entry in strategy");
+ ADD_FAILURE(); // Unexpected entry in strategy.
++iter;
}
« no previous file with comments | « build/common.gypi ('k') | chrome/browser/webdata/web_data_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698