base/debug/trace_event_unittest.cc - Issue 12258039: enable -Wstring-conversion when compiling with clang

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/debug/trace_event_unittest.cc

Issue 12258039: enable -Wstring-conversion when compiling with clang (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: enable on mac, better fix in web_data_service Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/debug/trace_event_unittest.cc

diff --git a/base/debug/trace_event_unittest.cc b/base/debug/trace_event_unittest.cc

index 15e11a70f4829a10ded2606e6f52d1fe1e5e0e92..78bcc238c34efbe7b07a4fdc28a343dfa07f2dce 100644

--- a/base/debug/trace_event_unittest.cc

+++ b/base/debug/trace_event_unittest.cc

@@ -73,7 +73,7 @@ class TraceEventTestFixture : public testing::Test {

void BeginTrace() {

event_watch_notification_ = 0;

- TraceLog::GetInstance()->SetEnabled("*");

+ TraceLog::GetInstance()->SetEnabled(std::string("*"));

}

void EndTraceAndFlush() {

« no previous file with comments | « no previous file | build/common.gypi » ('j') | no next file with comments »