Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Side by Side Diff: third_party/mesa/mesa.gyp

Issue 12258039: enable -Wstring-conversion when compiling with clang (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: enable on mac, better fix in web_data_service Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « third_party/libjingle/libjingle.gyp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 { 5 {
6 'variables': { 6 'variables': {
7 # Disable warnings as errors for mesa until they're fixed or disabled. 7 # Disable warnings as errors for mesa until they're fixed or disabled.
8 # http://crbug.com/143877 8 # http://crbug.com/143877
9 'win_third_party_warn_as_error': 'false', 9 'win_third_party_warn_as_error': 'false',
10 }, 10 },
(...skipping 525 matching lines...) Expand 10 before | Expand all | Expand 10 after
536 'conditions': [ 536 'conditions': [
537 ['clang == 1', { 537 ['clang == 1', {
538 'xcode_settings': { 538 'xcode_settings': {
539 'WARNING_CFLAGS': [ 539 'WARNING_CFLAGS': [
540 # Several functions ignore the result of talloc_steal(). 540 # Several functions ignore the result of talloc_steal().
541 '-Wno-unused-value', 541 '-Wno-unused-value',
542 # texenvprogram.c converts '~0' to a bitfield, which causes cl ang 542 # texenvprogram.c converts '~0' to a bitfield, which causes cl ang
543 # to warn that -1 is implicitly converted to 255. 543 # to warn that -1 is implicitly converted to 255.
544 '-Wno-constant-conversion', 544 '-Wno-constant-conversion',
545 ], 545 ],
546 'WARNING_CFLAGS!': [
547 # Don't warn about string->bool used in asserts.
548 '-Wstring-conversion',
549 ],
546 }, 550 },
547 'cflags': [ 551 'cflags': [
548 '-Wno-unused-value', 552 '-Wno-unused-value',
549 '-Wno-constant-conversion', 553 '-Wno-constant-conversion',
550 ], 554 ],
555 'cflags!': [
556 '-Wstring-conversion',
557 ],
551 }], 558 }],
552 ], 559 ],
553 }, 560 },
554 # Building this target will hide the native OpenGL shared library and 561 # Building this target will hide the native OpenGL shared library and
555 # replace it with a slow software renderer. 562 # replace it with a slow software renderer.
556 { 563 {
557 'target_name': 'osmesa', 564 'target_name': 'osmesa',
558 'type': 'loadable_module', 565 'type': 'loadable_module',
559 'mac_bundle': 0, 566 'mac_bundle': 0,
560 'dependencies': [ 567 'dependencies': [
(...skipping 61 matching lines...) Expand 10 before | Expand all | Expand 10 after
622 'type': 'none', 629 'type': 'none',
623 }, 630 },
624 { 631 {
625 'target_name': 'osmesa', 632 'target_name': 'osmesa',
626 'type': 'none', 633 'type': 'none',
627 }, 634 },
628 ], 635 ],
629 }], 636 }],
630 ], 637 ],
631 } 638 }
OLDNEW
« no previous file with comments | « third_party/libjingle/libjingle.gyp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698