Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(677)

Issue 12258030: Reload the web-app if an IT2Me connection fails. (Closed)

Created:
7 years, 10 months ago by Jamie
Modified:
7 years, 10 months ago
Reviewers:
garykac
CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, rmsousa+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

Reload the web-app if an IT2Me connection fails. The underlying cause of the referenced bug is that when I refactored the WCS code, I didn't support multiple calls to start(), thinking they were never needed because we always reload the web-app when a connection closes. Unfortunately, this misses the case of failed IT2Me connections where we previously returned the user to the access code entry screen to try again. This CL makes the IT2Me and Me2Me modes the same by reloading the web-app in both cases. This introduces a small regression insofar as mistyping an access code now means an extra reload and button click before trying again. LMK if you think this is unacceptable--I need to implement a cleaner flow for Apps v2 anyway, but that's likely to be unsuitable for merging to M26. BUG=175494 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182742

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -6 lines) Patch
M remoting/webapp/client_screen.js View 2 chunks +1 line, -4 lines 1 comment Download
M remoting/webapp/event_handlers.js View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Jamie
ptal https://codereview.chromium.org/12258030/diff/1/remoting/webapp/client_screen.js File remoting/webapp/client_screen.js (left): https://codereview.chromium.org/12258030/diff/1/remoting/webapp/client_screen.js#oldcode165 remoting/webapp/client_screen.js:165: } The only case where showConnectError is called ...
7 years, 10 months ago (2013-02-14 01:13:33 UTC) #1
garykac
lgtm
7 years, 10 months ago (2013-02-14 18:32:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamiewalch@chromium.org/12258030/1
7 years, 10 months ago (2013-02-14 18:35:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamiewalch@chromium.org/12258030/1
7 years, 10 months ago (2013-02-14 22:28:59 UTC) #4
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=11205
7 years, 10 months ago (2013-02-15 15:32:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamiewalch@chromium.org/12258030/1
7 years, 10 months ago (2013-02-15 17:19:19 UTC) #6
commit-bot: I haz the power
7 years, 10 months ago (2013-02-15 17:25:31 UTC) #7
Message was sent while issue was closed.
Change committed as 182742

Powered by Google App Engine
This is Rietveld 408576698