Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(451)

Issue 12258025: Fixes to prep_libc.py to support correct stripping of x64 libcmt on x64 target (Closed)

Created:
7 years, 10 months ago by Will Harris
Modified:
7 years, 10 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org, dmikurube+memory_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Fixes to prep_libc.py to support correct stripping of x64 libcmt on x64 target BUG=166496 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182457

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M base/allocator/prep_libc.py View 1 chunk +2 lines, -0 lines 1 comment Download

Messages

Total messages: 10 (0 generated)
Will Harris
now takes 64bit library on windows x64 builds
7 years, 10 months ago (2013-02-14 01:52:00 UTC) #1
jar (doing other things)
Although I have readability in python, I'm not familiar with this code, and would prefer ...
7 years, 10 months ago (2013-02-14 01:59:43 UTC) #2
rvargas (doing something else)
lgtm https://codereview.chromium.org/12258025/diff/1/base/allocator/prep_libc.py File base/allocator/prep_libc.py (right): https://codereview.chromium.org/12258025/diff/1/base/allocator/prep_libc.py#newcode13 base/allocator/prep_libc.py:13: # C:\Program Files\Microsoft Visual Studio 8\VC\ This should ...
7 years, 10 months ago (2013-02-14 02:37:11 UTC) #3
jschuh
lgtm++
7 years, 10 months ago (2013-02-14 02:42:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wfh@chromium.org/12258025/1
7 years, 10 months ago (2013-02-14 02:58:18 UTC) #5
commit-bot: I haz the power
Presubmit check for 12258025-1 failed and returned exit status 1. INFO:root:Found 1 file(s). Running presubmit ...
7 years, 10 months ago (2013-02-14 02:58:20 UTC) #6
jar (doing other things)
rubber stamp for Ricardo LGTM
7 years, 10 months ago (2013-02-14 03:24:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wfh@chromium.org/12258025/1
7 years, 10 months ago (2013-02-14 04:13:52 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wfh@chromium.org/12258025/1
7 years, 10 months ago (2013-02-14 14:06:39 UTC) #9
commit-bot: I haz the power
7 years, 10 months ago (2013-02-14 14:19:50 UTC) #10
Message was sent while issue was closed.
Change committed as 182457

Powered by Google App Engine
This is Rietveld 408576698