Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 12258004: [cc] Pass metadata about a tile to the raster system for benchmarks (Closed)

Created:
7 years, 10 months ago by nduca
Modified:
7 years, 10 months ago
Reviewers:
reveman, google-reveman
CC:
chromium-reviews, cc-bugs_chromium.org
Visibility:
Public.

Description

[cc] Pass metadata about a tile to the raster system for benchmarks There are a variety of benchmarks that want to measure the cost of raster for now bin only, and similarly, only for low res tiles. This patch provides very primitive infrastructure for this. R=reveman CC=egraether,skyostil BUG=175976 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182216

Patch Set 1 #

Total comments: 3

Patch Set 2 : nitfix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -2 lines) Patch
M cc/tile_manager.h View 1 2 chunks +7 lines, -0 lines 0 comments Download
M cc/tile_manager.cc View 1 4 chunks +19 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
nduca
7 years, 10 months ago (2013-02-13 10:16:15 UTC) #1
reveman
lgtm, just address feedback before landing https://codereview.chromium.org/12258004/diff/1/cc/tile_manager.cc File cc/tile_manager.cc (right): https://codereview.chromium.org/12258004/diff/1/cc/tile_manager.cc#newcode762 cc/tile_manager.cc:762: namespace { we ...
7 years, 10 months ago (2013-02-13 10:24:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nduca@chromium.org/12258004/6001
7 years, 10 months ago (2013-02-13 10:34:53 UTC) #3
commit-bot: I haz the power
7 years, 10 months ago (2013-02-13 14:38:14 UTC) #4
Message was sent while issue was closed.
Change committed as 182216

Powered by Google App Engine
This is Rietveld 408576698