Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 12257032: Fix function key translation. (Closed)

Created:
7 years, 10 months ago by Seigo Nonaka
Modified:
7 years, 10 months ago
Reviewers:
Zachary Kuznia
CC:
chromium-reviews, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org, yusukes+watch_chromium.org
Visibility:
Public.

Description

Fix function key translation. In the case of ChromeOS, function keys are no longer passed because they are re-written in c/b/ui/ash/event_rewriter.cc BUG=None TEST=Manually done. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182464

Patch Set 1 #

Patch Set 2 : Adding necessary headers. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M chrome/browser/chromeos/input_method/ibus_keymap.cc View 1 2 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Seigo Nonaka
7 years, 10 months ago (2013-02-14 11:37:10 UTC) #1
Zachary Kuznia
lgtm
7 years, 10 months ago (2013-02-14 11:40:05 UTC) #2
Seigo Nonaka
Thank you for your quick review!
7 years, 10 months ago (2013-02-14 11:40:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nona@chromium.org/12257032/1
7 years, 10 months ago (2013-02-14 11:41:10 UTC) #4
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 10 months ago (2013-02-14 12:10:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nona@chromium.org/12257032/7002
7 years, 10 months ago (2013-02-14 12:20:53 UTC) #6
commit-bot: I haz the power
7 years, 10 months ago (2013-02-14 14:51:18 UTC) #7
Message was sent while issue was closed.
Change committed as 182464

Powered by Google App Engine
This is Rietveld 408576698