Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Issue 12257030: Android: further "user build" perf test automation. (Closed)

Created:
7 years, 10 months ago by bulach
Modified:
7 years, 10 months ago
Reviewers:
Sami
CC:
chromium-reviews, klundberg+watch_chromium.org, frankf+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy+watch_chromium.org
Visibility:
Public.

Description

Android: further "user build" perf test automation. Follow up from r182261. |su| on some devices return '', others some combination of line-ending, and some nothing at all. BUG=175127 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182478

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M build/android/pylib/android_commands.py View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
bulach
i hope this will be the last, sigh...
7 years, 10 months ago (2013-02-14 09:45:30 UTC) #1
Sami
Jeez, how many differences can there be... lgtm.
7 years, 10 months ago (2013-02-14 10:56:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bulach@chromium.org/12257030/1
7 years, 10 months ago (2013-02-14 11:39:45 UTC) #3
bulach
more than I could ever possibly want :) thanks, CQing..
7 years, 10 months ago (2013-02-14 11:40:19 UTC) #4
commit-bot: I haz the power
7 years, 10 months ago (2013-02-14 16:49:59 UTC) #5
Message was sent while issue was closed.
Change committed as 182478

Powered by Google App Engine
This is Rietveld 408576698