Change call_new_handler to be non extern C; not called outside this code and it's causing issues wi…

Change call_new_handler to be non extern C; not called outside this code and it's causing issues with the linker on Win-64

BUG=166496
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182788

[Will Harris, 2013-02-15 00:04:12]

Windows 64 bit compiler was complaining about a function that was extern "C"
trying to throw exceptions so I've moved the extern "C" to only cover those
parts being shimmed, leaving the call_new_handler as C++ - the code is not
called from anywhere non-CC. Thoughts?

[jar (doing other things), 2013-02-15 00:39:37]

... please clean up the other nearby nits.

then LGTM.

(Thanks for doing the first return false fix!  Note that if we have to merge
code with third parties, we typically leave stuff like this in, so that it
merges easier... but this is our shim code, and doesn't need to merge, so it may
as well be cleaner).

https://codereview.chromium.org/12256047/diff/1/base/allocator/allocator_shim.cc
File base/allocator/allocator_shim.cc (right):

https://codereview.chromium.org/12256047/diff/1/base/allocator/allocator_shim...
base/allocator/allocator_shim.cc:89: #if (defined(__GNUC__) &&
!defined(__EXCEPTIONS)) || (defined(_HAS_EXCEPTIONS) && !_HAS_EXCEPTIONS)
nit: wrap at 80 characters with backslash

https://codereview.chromium.org/12256047/diff/1/base/allocator/allocator_shim...
base/allocator/allocator_shim.cc:100: return 0;
nit: return false

[Will Harris, 2013-02-15 07:33:12]

thanks for the prompt review.  Happy valentine's day!

https://codereview.chromium.org/12256047/diff/1/base/allocator/allocator_shim.cc
File base/allocator/allocator_shim.cc (right):

https://codereview.chromium.org/12256047/diff/1/base/allocator/allocator_shim...
base/allocator/allocator_shim.cc:89: #if (defined(__GNUC__) &&
!defined(__EXCEPTIONS)) || (defined(_HAS_EXCEPTIONS) && !_HAS_EXCEPTIONS)
On 2013/02/15 00:39:37, jar wrote:
> nit: wrap at 80 characters with backslash

Done.

https://codereview.chromium.org/12256047/diff/1/base/allocator/allocator_shim...
base/allocator/allocator_shim.cc:100: return 0;
On 2013/02/15 00:39:37, jar wrote:
> nit: return false

Done.

[commit-bot: I haz the power, 2013-02-15 07:41:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wfh@chromium.org/12256047/6001

[jar (doing other things), 2013-02-15 17:19:55]

lgtm

[commit-bot: I haz the power, 2013-02-15 19:37:15]

Change committed as 182788