Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1705)

Unified Diff: chrome/browser/extensions/startup_helper.cc

Issue 12256041: Fix a bug where extensions created with locale info from the command line is broken. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: ManifestHandler in StartupHelper Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/startup_helper.cc
diff --git a/chrome/browser/extensions/startup_helper.cc b/chrome/browser/extensions/startup_helper.cc
index 63ba15f49a49d29252f2fc2f3ae0a6607a396aea..fefd492ed0c214657ad09a52f55017d71eef0d0e 100644
--- a/chrome/browser/extensions/startup_helper.cc
+++ b/chrome/browser/extensions/startup_helper.cc
@@ -13,7 +13,10 @@
#include "chrome/browser/extensions/webstore_standalone_installer.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/common/chrome_switches.h"
+#include "chrome/common/extensions/api/i18n/default_locale_handler.h"
#include "chrome/common/extensions/extension.h"
+#include "chrome/common/extensions/extension_manifest_constants.h"
+#include "chrome/common/extensions/manifest_handler.h"
#include "content/public/browser/web_contents.h"
#include "ipc/ipc_message.h"
@@ -27,7 +30,10 @@ void PrintPackExtensionMessage(const std::string& message) {
namespace extensions {
-StartupHelper::StartupHelper() : pack_job_succeeded_(false) {}
+StartupHelper::StartupHelper() : pack_job_succeeded_(false) {
+ ManifestHandler::Register(extension_manifest_keys::kDefaultLocale,
+ make_linked_ptr(new DefaultLocaleHandler));
+}
void StartupHelper::OnPackSuccess(
const base::FilePath& crx_path,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698