Issue 12256038: Register dependent codes before populating deoptimization data, which can cause GC.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12256038: Register dependent codes before populating deoptimization data, which can cause GC. (Closed)

Created:
7 years, 10 months ago by ulan

Modified:
7 years, 10 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Register dependent codes before populating deoptimization data, which can cause GC. R=mstarzinger@chromium.org BUG=crash on nosnap-debug with stress-compaction Committed: https://code.google.com/p/v8/source/detail?r=13669

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+116 lines, -30 lines)			Patch
M	src/arm/lithium-codegen-arm.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/arm/lithium-codegen-arm.cc	View	2 chunks	+28 lines, -0 lines	0 comments	Download
M	src/ia32/lithium-codegen-ia32.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/ia32/lithium-codegen-ia32.cc	View	2 chunks	+28 lines, -0 lines	0 comments	Download
M	src/lithium.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/lithium.cc	View	2 chunks	+0 lines, -28 lines	0 comments	Download
M	src/mips/lithium-codegen-mips.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/mips/lithium-codegen-mips.cc	View	2 chunks	+28 lines, -0 lines	0 comments	Download
M	src/x64/lithium-codegen-x64.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/x64/lithium-codegen-x64.cc	View	2 chunks	+28 lines, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

Michael Starzinger

7 years, 10 months ago (2013-02-14 13:46:43 UTC) #2

LGTM. I just reviewed ia32, since I assume the other architectures are just a
copy of that.