Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1613)

Unified Diff: chrome/browser/instant/instant_service.h

Issue 12256029: Use scoped_ptr to document ownership in InstantUnloadHandler. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: More correct ownership semantics Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/instant/instant_commit_type.h ('k') | chrome/browser/instant/instant_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/instant/instant_service.h
diff --git a/chrome/browser/instant/instant_service.h b/chrome/browser/instant/instant_service.h
index b3639fb23c1b56252d67808555d4476160f1b632..9bf8f5d64851cf2b80807dab6090ba25e92f2824 100644
--- a/chrome/browser/instant/instant_service.h
+++ b/chrome/browser/instant/instant_service.h
@@ -13,7 +13,7 @@
#include "content/public/browser/notification_observer.h"
#include "content/public/browser/notification_registrar.h"
-// Tracks render process host ids that are associated with Instant.
+// Tracks render process host IDs that are associated with Instant.
class InstantService : public ProfileKeyedService,
public content::NotificationObserver {
public:
@@ -25,13 +25,17 @@ class InstantService : public ProfileKeyedService,
void AddInstantProcess(int process_id);
bool IsInstantProcess(int process_id) const;
- // For testing.
- int GetInstantProcessCount() const;
+#if defined(UNIT_TEST)
+ int GetInstantProcessCount() const {
+ return process_ids_.size();
+ }
+#endif
private:
- // ProfileKeyedService:
+ // Overridden from ProfileKeyedService:
virtual void Shutdown() OVERRIDE;
+ // Overridden from content::NotificationObserver:
virtual void Observe(int type,
const content::NotificationSource& source,
const content::NotificationDetails& details) OVERRIDE;
« no previous file with comments | « chrome/browser/instant/instant_commit_type.h ('k') | chrome/browser/instant/instant_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698