Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(663)

Issue 12256014: Add default import libraries to common GYP config in preparation for GYP changes that remove defaul… (Closed)

Created:
7 years, 10 months ago by Sigurður Ásgeirsson
Modified:
7 years, 10 months ago
Reviewers:
scottmg
CC:
chromium-reviews
Visibility:
Public.

Description

Add default import libraries to common GYP config in preparation for GYP changes that remove default library configuration. R=scottmg@chromium.org BUG=176040 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182699

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -0 lines) Patch
M build/common.gypi View 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Sigurður Ásgeirsson
7 years, 10 months ago (2013-02-13 18:20:48 UTC) #1
scottmg
lgtm
7 years, 10 months ago (2013-02-13 18:22:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/siggi@chromium.org/12256014/1
7 years, 10 months ago (2013-02-13 19:55:33 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) chrome_frame_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=111452
7 years, 10 months ago (2013-02-13 23:00:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/siggi@chromium.org/12256014/1
7 years, 10 months ago (2013-02-14 13:38:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/siggi@chromium.org/12256014/1
7 years, 10 months ago (2013-02-14 13:38:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/siggi@chromium.org/12256014/1
7 years, 10 months ago (2013-02-14 22:27:12 UTC) #7
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=11118
7 years, 10 months ago (2013-02-15 11:21:34 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/siggi@chromium.org/12256014/1
7 years, 10 months ago (2013-02-15 13:46:44 UTC) #9
commit-bot: I haz the power
7 years, 10 months ago (2013-02-15 13:48:41 UTC) #10
Message was sent while issue was closed.
Change committed as 182699

Powered by Google App Engine
This is Rietveld 408576698