Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 12256013: [MIPS] Fix missing definitions for MIPS arch in build and driver scripts (Closed)

Created:
7 years, 10 months ago by petarj
Modified:
7 years, 10 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
http://git.chromium.org/native_client/src/native_client.git@master
Visibility:
Public.

Description

[MIPS] Fix missing definitions for MIPS arch in build and driver scripts pnacl/build.sh and pnacl/driver/* scripts missed MIPS arch in a couple of places. The toolchain can be built for MIPS now. BUG= https://code.google.com/p/nativeclient/issues/detail?id=2275 TEST= pnacl/build.sh all Committed: http://src.chromium.org/viewvc/native_client?view=rev&revision=10814

Patch Set 1 #

Total comments: 6

Patch Set 2 : Update per code review. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -17 lines) Patch
M pnacl/build.sh View 2 chunks +2 lines, -0 lines 0 comments Download
M pnacl/driver/driver_env.py View 1 3 chunks +10 lines, -5 lines 0 comments Download
M pnacl/driver/driver_tools.py View 2 chunks +2 lines, -0 lines 0 comments Download
M pnacl/driver/pnacl-driver.py View 1 1 chunk +1 line, -0 lines 0 comments Download
M pnacl/driver/pnacl-ld.py View 1 chunk +8 lines, -6 lines 0 comments Download
M pnacl/driver/pnacl-nativeld.py View 1 chunk +8 lines, -6 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
petarj
7 years, 10 months ago (2013-02-13 18:52:23 UTC) #1
Mark Seaborn
LGTM, but please ensure toolchain trybots pass before committing. https://codereview.chromium.org/12256013/diff/1/pnacl/driver/pnacl-driver.py File pnacl/driver/pnacl-driver.py (right): https://codereview.chromium.org/12256013/diff/1/pnacl/driver/pnacl-driver.py#newcode59 pnacl/driver/pnacl-driver.py:59: ...
7 years, 10 months ago (2013-02-13 19:17:52 UTC) #2
jvoung - send to chromium...
https://codereview.chromium.org/12256013/diff/1/pnacl/driver/driver_env.py File pnacl/driver/driver_env.py (right): https://codereview.chromium.org/12256013/diff/1/pnacl/driver/driver_env.py#newcode67 pnacl/driver/driver_env.py:67: 'BIAS' : 'NONE', # This can be 'NONE', 'ARM', ...
7 years, 10 months ago (2013-02-13 19:30:43 UTC) #3
petarj
https://codereview.chromium.org/12256013/diff/1/pnacl/driver/pnacl-driver.py File pnacl/driver/pnacl-driver.py (right): https://codereview.chromium.org/12256013/diff/1/pnacl/driver/pnacl-driver.py#newcode59 pnacl/driver/pnacl-driver.py:59: 'BIAS_MIPS32' : '-D__MIPS__ -D__mips__ -D__MIPSEL__ -U__MIPSEB__', On 2013/02/13 19:17:52, ...
7 years, 10 months ago (2013-02-13 20:45:01 UTC) #4
Mark Seaborn
https://codereview.chromium.org/12256013/diff/1/pnacl/driver/pnacl-driver.py File pnacl/driver/pnacl-driver.py (right): https://codereview.chromium.org/12256013/diff/1/pnacl/driver/pnacl-driver.py#newcode59 pnacl/driver/pnacl-driver.py:59: 'BIAS_MIPS32' : '-D__MIPS__ -D__mips__ -D__MIPSEL__ -U__MIPSEB__', On 2013/02/13 20:45:02, ...
7 years, 10 months ago (2013-02-13 20:53:17 UTC) #5
petarj
Second patch set uploaded. https://codereview.chromium.org/12256013/diff/1/pnacl/driver/driver_env.py File pnacl/driver/driver_env.py (right): https://codereview.chromium.org/12256013/diff/1/pnacl/driver/driver_env.py#newcode67 pnacl/driver/driver_env.py:67: 'BIAS' : 'NONE', # This ...
7 years, 10 months ago (2013-02-14 01:06:52 UTC) #6
jvoung - send to chromium...
LGTM
7 years, 10 months ago (2013-02-14 01:37:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://nativeclient-status.appspot.com/cq/petarj@mips.com/12256013/8001
7 years, 10 months ago (2013-02-14 17:30:35 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://nativeclient-status.appspot.com/cq/petarj@mips.com/12256013/8001
7 years, 10 months ago (2013-02-14 17:47:58 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://nativeclient-status.appspot.com/cq/petarj@mips.com/12256013/8001
7 years, 10 months ago (2013-02-14 17:58:09 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://nativeclient-status.appspot.com/cq/petarj@mips.com/12256013/8001
7 years, 10 months ago (2013-02-14 18:08:33 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://nativeclient-status.appspot.com/cq/petarj@mips.com/12256013/8001
7 years, 10 months ago (2013-02-14 18:10:44 UTC) #12
commit-bot: I haz the power
7 years, 10 months ago (2013-02-14 20:32:36 UTC) #13
Message was sent while issue was closed.
Change committed as 10814

Powered by Google App Engine
This is Rietveld 408576698