Issue 12255048: Fix lint error in git_wktry.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12255048: Fix lint error in git_wktry. (Closed)

Created:
7 years, 10 months ago by Torne

Modified:
7 years, 10 months ago

Reviewers:
tony, M-A Ruel

CC:
chromium-reviews, Dirk Pranke, cmp+cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master

Visibility:
Public.

More Reviews

Description

Fix lint error in git_wktry. gpylint doesn't like the use of "type" as a variable name (redefining a builtin) - change the signature of the method to use the exc_ prefix like sys.exc_*. The variables are not actually used anyway. BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=182722

Patch Set 1 #

Total comments: 1

Patch Set 2 : prefix unused args #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	git_wktry.py	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Torne

Got a presubmit warning when trying to upload a different change, and it's trivial, so ...

7 years, 10 months ago (2013-02-15 12:30:10 UTC) #1

M-A Ruel

lgtm https://codereview.chromium.org/12255048/diff/1/git_wktry.py File git_wktry.py (right): https://codereview.chromium.org/12255048/diff/1/git_wktry.py#newcode26 git_wktry.py:26: def __exit__(self, exc_type, exc_value, exc_traceback): Prepend unused arguments ...

7 years, 10 months ago (2013-02-15 15:59:42 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/torne@chromium.org/12255048/5001

7 years, 10 months ago (2013-02-15 16:02:31 UTC) #3

Message was sent while issue was closed.

Change committed as 182722

Expand Messages | Collapse Messages