Issue 12255043: DBus: Use TaskRunners instead of MessageLoopProxies.

Issue 12255043: DBus: Use TaskRunners instead of MessageLoopProxies. (Closed)

Created:
7 years, 10 months ago by Lei Zhang

Modified:
7 years, 5 months ago

Reviewers:
satorux1

CC:
chromium-reviews, tfarina

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

DBus: Use TaskRunners instead of MessageLoopProxies. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=183362

Patch Set 2 : rebase #

Total comments: 2

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+78 lines, -83 lines)			Patch
M	chromeos/dbus/blocking_method_caller.cc	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	chromeos/dbus/dbus_thread_manager.cc	View	1	2 chunks	+2 lines, -4 lines	0 comments	Download
M	dbus/bus.h	View	1	5 chunks	+26 lines, -23 lines	0 comments	Download
M	dbus/bus.cc	View	1	11 chunks	+27 lines, -29 lines	0 comments	Download
M	dbus/bus_unittest.cc	View	1	3 chunks	+3 lines, -3 lines	0 comments	Download
M	dbus/end_to_end_async_unittest.cc	View	1	3 chunks	+3 lines, -5 lines	0 comments	Download
M	dbus/mock_bus.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	dbus/mock_bus.cc	View	1	1 chunk	+3 lines, -1 line	2 comments	Download
M	dbus/property_unittest.cc	View	1	3 chunks	+2 lines, -4 lines	0 comments	Download
M	dbus/signal_sender_verification_unittest.cc	View	1	4 chunks	+2 lines, -5 lines	0 comments	Download
M	dbus/test_server.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	dbus/test_service.h	View	1	3 chunks	+4 lines, -4 lines	0 comments	Download
M	dbus/test_service.cc	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	device/media_transfer_protocol/media_transfer_protocol_manager.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/12255043/15001

7 years, 10 months ago (2013-02-19 19:57:20 UTC) #3

commit-bot: I haz the power

Failed to apply patch for dbus/end_to_end_async_unittest.cc: While running patch -p0 --forward --force --no-backup-if-mismatch; patching file ...

7 years, 10 months ago (2013-02-19 19:57:31 UTC) #4

Failed to apply patch for dbus/end_to_end_async_unittest.cc:
While running patch -p0 --forward --force --no-backup-if-mismatch;
  patching file dbus/end_to_end_async_unittest.cc
  Hunk #1 succeeded at 46 (offset -1 lines).
  Hunk #2 succeeded at 138 with fuzz 2 (offset 81 lines).
  Hunk #3 FAILED at 136.
  1 out of 3 hunks FAILED -- saving rejects to file
dbus/end_to_end_async_unittest.cc.rej

Patch:       dbus/end_to_end_async_unittest.cc
Index: dbus/end_to_end_async_unittest.cc
===================================================================
--- dbus/end_to_end_async_unittest.cc	(revision 182521)
+++ dbus/end_to_end_async_unittest.cc	(working copy)
@@ -47,7 +47,7 @@
 
     // Start the test service, using the D-Bus thread.
     dbus::TestService::Options options;
-    options.dbus_thread_message_loop_proxy =
dbus_thread_->message_loop_proxy();
+    options.dbus_task_runner = dbus_thread_->message_loop_proxy();
     test_service_.reset(new dbus::TestService(options));
     ASSERT_TRUE(test_service_->StartService());
     ASSERT_TRUE(test_service_->WaitUntilServiceIsStarted());
@@ -57,8 +57,7 @@
     dbus::Bus::Options bus_options;
     bus_options.bus_type = dbus::Bus::SESSION;
     bus_options.connection_type = dbus::Bus::PRIVATE;
-    bus_options.dbus_thread_message_loop_proxy =
-        dbus_thread_->message_loop_proxy();
+    bus_options.dbus_task_runner = dbus_thread_->message_loop_proxy();
     bus_ = new dbus::Bus(bus_options);
     object_proxy_ = bus_->GetObjectProxy(
         "org.chromium.TestService",
@@ -137,8 +136,7 @@
     bus_options.bus_type = dbus::Bus::CUSTOM_ADDRESS;
     bus_options.address = kInvalidAddress;
     bus_options.connection_type = dbus::Bus::PRIVATE;
-    bus_options.dbus_thread_message_loop_proxy =
-        dbus_thread_->message_loop_proxy();
+    bus_options.dbus_task_runner = dbus_thread_->message_loop_proxy();
     bus_ = new dbus::Bus(bus_options);
     ASSERT_TRUE(bus_->HasDBusThread());

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/12255043/32001

7 years, 10 months ago (2013-02-19 23:16:15 UTC) #5

tfarina

https://chromiumcodereview.appspot.com/12255043/diff/32001/dbus/mock_bus.cc File dbus/mock_bus.cc (right): https://chromiumcodereview.appspot.com/12255043/diff/32001/dbus/mock_bus.cc#newcode7 dbus/mock_bus.cc:7: #include "base/location.h" I don't believe this include was needed ...

7 years, 5 months ago (2013-06-29 02:44:47 UTC) #7

Lei Zhang

7 years, 5 months ago (2013-06-29 02:50:18 UTC) #8

Message was sent while issue was closed.

https://chromiumcodereview.appspot.com/12255043/diff/32001/dbus/mock_bus.cc
File dbus/mock_bus.cc (right):

https://chromiumcodereview.appspot.com/12255043/diff/32001/dbus/mock_bus.cc#n...
dbus/mock_bus.cc:7: #include "base/location.h"
On 2013/06/29 02:44:47, tfarina wrote:
> I don't believe this include was needed here. Was it?

Hmm, doesn't look like. Feel free to remove it.

Expand Messages | Collapse Messages