Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5513)

Unified Diff: chrome/common/extensions/extension.cc

Issue 12255041: Extension BaseFeatureProvider minor cleanups. Don't crash in release mode if we failed to parse a p… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: kalman@ comments Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/common/extensions/features/base_feature_provider.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/extension.cc
diff --git a/chrome/common/extensions/extension.cc b/chrome/common/extensions/extension.cc
index b19e3fb892f3f7640ae840ec70639b938e56091b..5cb08067560f211d0ca11ed3395aaa5f8c61480e 100644
--- a/chrome/common/extensions/extension.cc
+++ b/chrome/common/extensions/extension.cc
@@ -601,7 +601,10 @@ bool Extension::ParsePermissions(const char* key,
// The feature should exist since we just got an APIPermission
// for it. The two systems should be updated together whenever a
// permission is added.
- CHECK(feature);
+ DCHECK(feature);
+ // http://crbug.com/176381
+ if (!feature)
+ continue;
Feature::Availability availability =
feature->IsAvailableToManifest(
« no previous file with comments | « no previous file | chrome/common/extensions/features/base_feature_provider.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698