Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 12255031: ARM: Change signature for vmov.32 function in the assembler (Closed)

Created:
7 years, 10 months ago by hans
Modified:
7 years, 10 months ago
Reviewers:
ulan
CC:
v8-dev
Visibility:
Public.

Description

ARM: Change signature for vmov.32 function in the assembler The assembler has 8 different vmov variants. The one for vmov.32 and for moving an immediate into a double reg only differs in the type of the second paremeter: vmov.32 takes an int, the other takes a double. The situation is dangerous because C++ will happily implicitly convert between int and double. This patch changes the signature of the vmov.32 assembler function so that it cannot be confused with the other vmovs. BUG=none Committed: https://code.google.com/p/v8/source/detail?r=13668

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -14 lines) Patch
M src/arm/assembler-arm.h View 2 chunks +6 lines, -2 lines 0 comments Download
M src/arm/assembler-arm.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M test/cctest/test-assembler-arm.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M test/cctest/test-disasm-arm.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
hans
Ulan: Please take a look.
7 years, 10 months ago (2013-02-14 12:08:56 UTC) #1
ulan
LGTM, I will land this for you.
7 years, 10 months ago (2013-02-14 12:13:07 UTC) #2
ulan
7 years, 10 months ago (2013-02-14 12:28:09 UTC) #3
Message was sent while issue was closed.
Committed manually as r13668 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698