Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4871)

Unified Diff: bin/socket.cc

Issue 12255018: Add typed data interface to Dart API, this only changes the C++ API as dicussed in a previous email… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « bin/secure_socket.cc ('k') | include/dart_api.h » ('j') | include/dart_api.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: bin/socket.cc
===================================================================
--- bin/socket.cc (revision 18484)
+++ bin/socket.cc (working copy)
@@ -180,15 +180,18 @@
intptr_t total_bytes_written = 0;
intptr_t bytes_written = 0;
- if (Dart_IsByteArrayExternal(buffer_obj)) {
+ if (Dart_IsExternalTypedData(buffer_obj) != kInvalid) {
+ Dart_TypedData_Type type;
void* buffer = NULL;
- result = Dart_ExternalByteArrayGetData(buffer_obj, &buffer);
+ intptr_t len;
+ result = Dart_TypedDataAcquireData(buffer_obj, &type, &buffer, &len);
if (Dart_IsError(result)) {
Dart_PropagateError(result);
}
buffer = static_cast<void*>((static_cast<uint8_t*>(buffer) + offset));
bytes_written = Socket::Write(socket, buffer, length);
if (bytes_written > 0) total_bytes_written = bytes_written;
+ Dart_TypedDataReleaseData(buffer_obj);
} else {
// Send data in chunks of maximum 16KB.
const intptr_t max_chunk_length =
« no previous file with comments | « bin/secure_socket.cc ('k') | include/dart_api.h » ('j') | include/dart_api.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698