Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Unified Diff: chrome/test/chromedriver/run_all_tests.py

Issue 12255013: [chromedriver] Fix run_all_tests to return correct exit code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/chromedriver/run_all_tests.py
diff --git a/chrome/test/chromedriver/run_all_tests.py b/chrome/test/chromedriver/run_all_tests.py
index b85c14b7bee4daa6f10449d73f3824e909f09d2c..e50ba8b05c5dbdc87dbbd6f01ff323fbce009001 100755
--- a/chrome/test/chromedriver/run_all_tests.py
+++ b/chrome/test/chromedriver/run_all_tests.py
@@ -45,8 +45,10 @@ def RunPythonTests(chromedriver, chrome):
if util.IsMac():
# In Mac, chromedriver2.so is a 32-bit build, so run with the 32-bit python.
os.environ['VERSIONER_PYTHON_PREFER_32_BIT'] = 'yes'
- if util.RunCommand(cmd):
+ code = util.RunCommand(cmd)
+ if code:
print '@@@STEP_FAILURE@@@'
+ return code
def RunJavaTests(chromedriver, chrome):
@@ -57,14 +59,18 @@ def RunJavaTests(chromedriver, chrome):
'--chromedriver=' + chromedriver,
'--chrome=' + chrome,
]
- if util.RunCommand(cmd):
+ code = util.RunCommand(cmd)
+ if code:
print '@@@STEP_FAILURE@@@'
+ return code
def RunCppTests(cpp_tests):
print '@@@BUILD_STEP chromedriver2_tests@@@'
- if util.RunCommand([cpp_tests]):
+ code = util.RunCommand([cpp_tests])
+ if code:
print '@@@STEP_FAILURE@@@'
+ return code
def main():
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698