Issue 12255007: Split pref_service_unittest into generic vs. Chrome-specific parts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12255007: Split pref_service_unittest into generic vs. Chrome-specific parts. (Closed)

Created:
7 years, 10 months ago by Jói

Modified:
7 years, 10 months ago

Reviewers:
Mattias Nissler (ping if slow)

CC:
chromium-reviews, blundell

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Split pref_service_unittest into generic vs. Chrome-specific parts. BUG=155525 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182238

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -540 lines)			Patch
M	chrome/browser/prefs/DEPS	View	1	1 chunk	+0 lines, -15 lines	0 comments	Download
A +	chrome/browser/prefs/chrome_pref_service_unittest.cc	View	1	6 chunks	+8 lines, -319 lines	0 comments	Download
M	chrome/browser/prefs/pref_service_unittest.cc	View	1	8 chunks	+11 lines, -206 lines	0 comments	Download
M	chrome/chrome_tests_unit.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

Jói

Next step of moving remaining generic test code to base/prefs/. My next change will be ...

7 years, 10 months ago (2013-02-13 12:51:56 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joi@chromium.org/12255007/2001

7 years, 10 months ago (2013-02-13 13:18:13 UTC) #3

Message was sent while issue was closed.

Change committed as 182238