Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(563)

Issue 12255005: Adding rule frames to the ONC spec. (Closed)

Created:
7 years, 10 months ago by pneubeck (no reviews)
Modified:
7 years, 10 months ago
CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org
Visibility:
Public.

Description

Adding rule frames to the ONC spec. Also clarifying some of the field descriptions. BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182568

Patch Set 1 #

Total comments: 4

Patch Set 2 : Fixed linebreaks. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+152 lines, -71 lines) Patch
M chromeos/docs/onc_spec.css View 1 chunk +16 lines, -0 lines 0 comments Download
M chromeos/docs/onc_spec.html View 1 23 chunks +136 lines, -71 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
pneubeck (no reviews)
7 years, 10 months ago (2013-02-13 10:52:27 UTC) #1
David Roche
https://codereview.chromium.org/12255005/diff/1/chromeos/docs/onc_spec.html File chromeos/docs/onc_spec.html (right): https://codereview.chromium.org/12255005/diff/1/chromeos/docs/onc_spec.html#newcode433 chromeos/docs/onc_spec.html:433: <span class="rule_id"></span> Must be a number in the range ...
7 years, 10 months ago (2013-02-13 12:57:09 UTC) #2
pneubeck (no reviews)
https://codereview.chromium.org/12255005/diff/1/chromeos/docs/onc_spec.html File chromeos/docs/onc_spec.html (right): https://codereview.chromium.org/12255005/diff/1/chromeos/docs/onc_spec.html#newcode433 chromeos/docs/onc_spec.html:433: <span class="rule_id"></span> Must be a number in the range ...
7 years, 10 months ago (2013-02-13 13:09:15 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
7 years, 10 months ago (2013-02-13 13:55:04 UTC) #4
David Roche
lgtm
7 years, 10 months ago (2013-02-13 13:55:06 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
7 years, 10 months ago (2013-02-13 13:56:43 UTC) #6
pneubeck (no reviews)
@Greg, please take a look. CQ requires a full committer to review the CL.
7 years, 10 months ago (2013-02-13 13:58:04 UTC) #7
Greg Spencer (Chromium)
lgtm
7 years, 10 months ago (2013-02-13 17:20:22 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pneubeck@chromium.org/12255005/4001
7 years, 10 months ago (2013-02-14 09:35:40 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pneubeck@chromium.org/12255005/4001
7 years, 10 months ago (2013-02-14 22:26:43 UTC) #10
commit-bot: I haz the power
7 years, 10 months ago (2013-02-14 23:13:32 UTC) #11
Message was sent while issue was closed.
Change committed as 182568

Powered by Google App Engine
This is Rietveld 408576698