Issue 12255004: Remove workaround in WebrtcBrowserTest.CallWithDataAndMedia.

Issue 12255004: Remove workaround in WebrtcBrowserTest.CallWithDataAndMedia. (Closed)

Created:
7 years, 10 months ago by perkj_chrome

Modified:
7 years, 10 months ago

Reviewers:
phoglund_chromium, anagy4698

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, feature-media-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove workaround in WebrtcBrowserTest.CallWithDataAndMedia. The underlaying problem in http://code.google.com/p/webrtc/issues/detail?id=1262 has been fixed. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182642

Patch Set 2 : Addressed code review comment. #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -11 lines)			Patch
	M	content/test/data/media/peerconnection-call.html	View	1	1 chunk	+2 lines, -11 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

phoglund_chromium

One nit, otherwise lgtm https://codereview.chromium.org/12255004/diff/2001/content/test/data/media/peerconnection-call.html File content/test/data/media/peerconnection-call.html (right): https://codereview.chromium.org/12255004/diff/2001/content/test/data/media/peerconnection-call.html#newcode109 content/test/data/media/peerconnection-call.html:109: if (secondDataChannel.readyState == "open") { ...

7 years, 10 months ago (2013-02-13 10:34:47 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/perkj@chromium.org/12255004/9001

7 years, 10 months ago (2013-02-14 15:05:37 UTC) #3

anagy4698

2013/2/14 <commit-bot@chromium.org> > CQ is trying da patch. Follow status at > https://chromium-status.**appspot.com/cq/perkj@chromium.** > org/12255004/9001<https://chromium-status.appspot.com/cq/perkj@chromium.org/12255004/9001> ...

7 years, 10 months ago (2013-02-14 15:48:14 UTC) #4

commit-bot: I haz the power

List of reviewers changed. anagy4698@gmail.com did a drive-by without LGTM'ing!

7 years, 10 months ago (2013-02-14 18:23:05 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/perkj@chromium.org/12255004/9001

7 years, 10 months ago (2013-02-15 07:44:44 UTC) #6

Message was sent while issue was closed.

Change committed as 182642

Expand Messages | Collapse Messages