Adding annotation output for trybot.

Adding annotation output for trybot.

BUG=
NOTRY=true


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182474

[tonyg, 2013-02-14 00:17:46]

Two nits. Else looks good.

https://codereview.chromium.org/12254022/diff/1/tools/bisect-perf-regression.py
File tools/bisect-perf-regression.py (right):

https://codereview.chromium.org/12254022/diff/1/tools/bisect-perf-regression....
tools/bisect-perf-regression.py:801: OutputAnnotationStepStart('Bisection Range
[%s]' % depot)
depot seems like the wrong thing to print as the bisection range. Shouldn't it
be the first and last elem in revision_list?

https://codereview.chromium.org/12254022/diff/1/tools/bisect-perf-regression....
tools/bisect-perf-regression.py:1164: parser.add_option('--output_annotations',
I'd name this --buildbot_annotations or --output_buildbot_annotations

[shatch, 2013-02-14 01:16:01]

New snapshot uploaded.

https://codereview.chromium.org/12254022/diff/1/tools/bisect-perf-regression.py
File tools/bisect-perf-regression.py (right):

https://codereview.chromium.org/12254022/diff/1/tools/bisect-perf-regression....
tools/bisect-perf-regression.py:801: OutputAnnotationStepStart('Bisection Range
[%s]' % depot)
On 2013/02/14 00:17:47, tonyg wrote:
> depot seems like the wrong thing to print as the bisection range. Shouldn't it
> be the first and last elem in revision_list?

Done.

https://codereview.chromium.org/12254022/diff/1/tools/bisect-perf-regression....
tools/bisect-perf-regression.py:1164: parser.add_option('--output_annotations',
On 2013/02/14 00:17:47, tonyg wrote:
> I'd name this --buildbot_annotations or --output_buildbot_annotations

Done.

[tonyg, 2013-02-14 01:21:01]

lgtm

https://codereview.chromium.org/12254022/diff/4001/tools/bisect-perf-regressi...
File tools/bisect-perf-regression.py (right):

https://codereview.chromium.org/12254022/diff/4001/tools/bisect-perf-regressi...
tools/bisect-perf-regression.py:801: list_length = len(revision_list)
inline?

https://codereview.chromium.org/12254022/diff/4001/tools/bisect-perf-regressi...
tools/bisect-perf-regression.py:803: (revision_list[list_length-1],
revision_list[0])
indent continued line by 4 spaces

[shatch, 2013-02-14 01:37:47]

New snapshot uploaded.

https://codereview.chromium.org/12254022/diff/4001/tools/bisect-perf-regressi...
File tools/bisect-perf-regression.py (right):

https://codereview.chromium.org/12254022/diff/4001/tools/bisect-perf-regressi...
tools/bisect-perf-regression.py:801: list_length = len(revision_list)
On 2013/02/14 01:21:01, tonyg wrote:
> inline?

Done.

https://codereview.chromium.org/12254022/diff/4001/tools/bisect-perf-regressi...
tools/bisect-perf-regression.py:803: (revision_list[list_length-1],
revision_list[0])
On 2013/02/14 01:21:01, tonyg wrote:
> indent continued line by 4 spaces

Done.

[tonyg, 2013-02-14 01:59:46]

lgtm still

[commit-bot: I haz the power, 2013-02-14 16:26:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/simonhatch@chromium.org/12254022/9001

[commit-bot: I haz the power, 2013-02-14 16:26:45]

Change committed as 182474