Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Issue 12254022: Adding annotation output for trybot. (Closed)

Created:
7 years, 10 months ago by shatch
Modified:
7 years, 10 months ago
Reviewers:
tonyg
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Adding annotation output for trybot. BUG= NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182474

Patch Set 1 #

Total comments: 4

Patch Set 2 : Changes from review. #

Total comments: 4

Patch Set 3 : Changes from review. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -1 line) Patch
M tools/bisect-perf-regression.py View 1 2 11 chunks +55 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
shatch
7 years, 10 months ago (2013-02-13 22:58:25 UTC) #1
tonyg
Two nits. Else looks good. https://codereview.chromium.org/12254022/diff/1/tools/bisect-perf-regression.py File tools/bisect-perf-regression.py (right): https://codereview.chromium.org/12254022/diff/1/tools/bisect-perf-regression.py#newcode801 tools/bisect-perf-regression.py:801: OutputAnnotationStepStart('Bisection Range [%s]' % ...
7 years, 10 months ago (2013-02-14 00:17:46 UTC) #2
shatch
New snapshot uploaded. https://codereview.chromium.org/12254022/diff/1/tools/bisect-perf-regression.py File tools/bisect-perf-regression.py (right): https://codereview.chromium.org/12254022/diff/1/tools/bisect-perf-regression.py#newcode801 tools/bisect-perf-regression.py:801: OutputAnnotationStepStart('Bisection Range [%s]' % depot) On ...
7 years, 10 months ago (2013-02-14 01:16:01 UTC) #3
tonyg
lgtm https://codereview.chromium.org/12254022/diff/4001/tools/bisect-perf-regression.py File tools/bisect-perf-regression.py (right): https://codereview.chromium.org/12254022/diff/4001/tools/bisect-perf-regression.py#newcode801 tools/bisect-perf-regression.py:801: list_length = len(revision_list) inline? https://codereview.chromium.org/12254022/diff/4001/tools/bisect-perf-regression.py#newcode803 tools/bisect-perf-regression.py:803: (revision_list[list_length-1], revision_list[0]) ...
7 years, 10 months ago (2013-02-14 01:21:01 UTC) #4
shatch
New snapshot uploaded. https://codereview.chromium.org/12254022/diff/4001/tools/bisect-perf-regression.py File tools/bisect-perf-regression.py (right): https://codereview.chromium.org/12254022/diff/4001/tools/bisect-perf-regression.py#newcode801 tools/bisect-perf-regression.py:801: list_length = len(revision_list) On 2013/02/14 01:21:01, ...
7 years, 10 months ago (2013-02-14 01:37:47 UTC) #5
tonyg
lgtm still
7 years, 10 months ago (2013-02-14 01:59:46 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/simonhatch@chromium.org/12254022/9001
7 years, 10 months ago (2013-02-14 16:26:32 UTC) #7
commit-bot: I haz the power
7 years, 10 months ago (2013-02-14 16:26:45 UTC) #8
Message was sent while issue was closed.
Change committed as 182474

Powered by Google App Engine
This is Rietveld 408576698