chrome/common/extensions/api/extension_action/script_badge_manifest_unittest.cc - Issue 12253022: Manifest handler for all keys background-related.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/api/extension_action/script_badge_manifest_unittest.cc

Issue 12253022: Manifest handler for all keys background-related. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/api/extension_action/script_badge_handler.cc ('k') | chrome/common/extensions/api/file_handlers/file_handlers_parser.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/api/extension_action/script_badge_manifest_unittest.cc

diff --git a/chrome/common/extensions/api/extension_action/script_badge_manifest_unittest.cc b/chrome/common/extensions/api/extension_action/script_badge_manifest_unittest.cc

index 8dbdd7ac36dd4d14c2dcb4d4f307b911c62d2969..5142ab74386b164f967ec2541d6ff5ec2d087874 100644

--- a/chrome/common/extensions/api/extension_action/script_badge_manifest_unittest.cc

+++ b/chrome/common/extensions/api/extension_action/script_badge_manifest_unittest.cc

@@ -10,7 +10,6 @@

#include "chrome/common/extensions/extension_icon_set.h"

#include "chrome/common/extensions/extension_manifest_constants.h"

#include "chrome/common/extensions/feature_switch.h"

-#include "chrome/common/extensions/manifest_handler.h"

#include "chrome/common/extensions/manifest_tests/extension_manifest_test.h"

#include "extensions/common/install_warning.h"

#include "testing/gmock/include/gmock/gmock.h"

@@ -35,11 +34,8 @@ std::vector<InstallWarning> StripMissingFlagWarning(

class ScriptBadgeManifestTest : public ExtensionManifestTest {

protected:

virtual void SetUp() OVERRIDE {

- ExtensionManifestTest::SetUp();

- ManifestHandler::Register(extension_manifest_keys::kScriptBadge,

- make_linked_ptr(new ScriptBadgeHandler));

- ManifestHandler::Register(extension_manifest_keys::kIcons,

- make_linked_ptr(new IconsHandler));

+ (new IconsHandler)->Register();

+ (new ScriptBadgeHandler)->Register();

}

};