chrome/common/extensions/api/extension_action/browser_action_manifest_unittest.cc - Issue 12253022: Manifest handler for all keys background-related.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/api/extension_action/browser_action_manifest_unittest.cc

Issue 12253022: Manifest handler for all keys background-related. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/api/extension_action/browser_action_handler.cc ('k') | chrome/common/extensions/api/extension_action/page_action_handler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/api/extension_action/browser_action_manifest_unittest.cc

diff --git a/chrome/common/extensions/api/extension_action/browser_action_manifest_unittest.cc b/chrome/common/extensions/api/extension_action/browser_action_manifest_unittest.cc

index 338a2d9e52bee6576bac8b5f981297ff05aeba2f..84277176a74398350a4f4b3b613b706984f5dc22 100644

--- a/chrome/common/extensions/api/extension_action/browser_action_manifest_unittest.cc

+++ b/chrome/common/extensions/api/extension_action/browser_action_manifest_unittest.cc

@@ -7,7 +7,6 @@

#include "chrome/common/extensions/extension_builder.h"

#include "chrome/common/extensions/extension_icon_set.h"

#include "chrome/common/extensions/extension_manifest_constants.h"

-#include "chrome/common/extensions/manifest_handler.h"

#include "chrome/common/extensions/manifest_tests/extension_manifest_test.h"

#include "chrome/common/extensions/value_builder.h"

#include "extensions/common/error_utils.h"

@@ -22,8 +21,7 @@ class BrowserActionManifestTest : public ExtensionManifestTest {

protected:

virtual void SetUp() OVERRIDE {

ExtensionManifestTest::SetUp();

- ManifestHandler::Register(extension_manifest_keys::kBrowserAction,

- make_linked_ptr(new BrowserActionHandler));

+ (new BrowserActionHandler)->Register();

}

};