Issue 12253020: Enhance net internals/net log output for QUIC.

Issue 12253020: Enhance net internals/net log output for QUIC. (Closed)

Created:
7 years, 10 months ago by Ryan Hamilton

Modified:
7 years, 10 months ago

Reviewers:
eroman, mmenke

CC:
chromium-reviews, cbentzel+watch_chromium.org, eroman, darin-cc_chromium.org, arv+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Enhance net internals/net log output for QUIC. Fix use after free bug in initial implementation. Initially landed: 182331 Reverted: 182335 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182471

Patch Set 1 #

Patch Set 2 : Fix use after free #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+110 lines, -13 lines)			Patch
M	chrome/browser/resources/net_internals/quic_view.js	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	chrome/test/data/webui/net_internals/log_view_painter.js	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	net/base/net_log_event_type_list.h	View		1 chunk	+32 lines, -0 lines	0 comments	Download
M	net/base/net_log_source_type_list.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	net/quic/quic_client_session.h	View		3 chunks	+6 lines, -1 line	0 comments	Download
M	net/quic/quic_client_session.cc	View	1	4 chunks	+17 lines, -3 lines	0 comments	Download
M	net/quic/quic_client_session_test.cc	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	net/quic/quic_http_stream.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	net/quic/quic_http_stream.cc	View		4 chunks	+34 lines, -0 lines	0 comments	Download
M	net/quic/quic_http_stream_test.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	net/quic/quic_reliable_client_stream.h	View		2 chunks	+5 lines, -1 line	0 comments	Download
M	net/quic/quic_reliable_client_stream.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	net/quic/quic_reliable_client_stream_test.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	net/quic/quic_stream_factory.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Ryan Hamilton

Fixed the use-after-free. (Totally obvious in hindsight). I'll run in on the ASAN bot before ...

7 years, 10 months ago (2013-02-14 00:50:05 UTC) #1

mmenke

On 2013/02/14 00:50:05, Ryan Hamilton wrote: > Fixed the use-after-free. (Totally obvious in hindsight). > ...

7 years, 10 months ago (2013-02-14 00:55:18 UTC) #2

eroman

lgtm On Wed, Feb 13, 2013 at 4:55 PM, <mmenke@chromium.org> wrote: > On 2013/02/14 00:50:05, ...

7 years, 10 months ago (2013-02-14 01:28:20 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rch@chromium.org/12253020/2001

7 years, 10 months ago (2013-02-14 04:38:21 UTC) #4

commit-bot: I haz the power

Retried try job too often on linux_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=98918

7 years, 10 months ago (2013-02-14 07:33:01 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rch@chromium.org/12253020/2001

7 years, 10 months ago (2013-02-14 15:18:19 UTC) #6

Message was sent while issue was closed.

Change committed as 182471

Expand Messages | Collapse Messages