Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 12253004: Moving last generic Prefs implementation files to base/prefs/. (Closed)

Created:
7 years, 10 months ago by Jói
Modified:
7 years, 10 months ago
CC:
chromium-reviews, MAD, nkostylev+watch_chromium.org, dhollowa+watch_chromium.org, ahutter, browser-components-watch_chromium.org, Albert Bodenhamer, markusheintz_, stevenjb+watch_chromium.org, cbentzel+watch_chromium.org, jar (doing other things), benquan, Ilya Sherman, dbeam+watch-autofill_chromium.org, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, erikwright+watch_chromium.org, Avi (use Gerrit), creis+watch_chromium.org, derat+watch_chromium.org, oshima+watch_chromium.org, Raman Kakilate, sail+watch_chromium.org, Aaron Boodman, Dane Wallinga, dyu1, ajwong+watch_chromium.org, estade+watch_chromium.org, davemoore+watch_chromium.org, blundell
Visibility:
Public.

Description

Moving last generic Prefs implementation files to base/prefs/. This completes componentization of Prefs, although there are some remaining TODOs that were created during componentization and interface improvement that still need to be tackled. TBR=ben@chromium.org BUG=155525 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182485

Patch Set 1 #

Patch Set 2 : Merge LKGR #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -849 lines) Patch
M base/base.gyp View 2 chunks +6 lines, -0 lines 0 comments Download
A + base/prefs/pref_notifier_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + base/prefs/pref_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/prefs/public/pref_change_registrar_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/prefs/public/pref_member_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + base/prefs/testing_pref_service.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + base/prefs/testing_pref_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/about_flags_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autofill/risk/fingerprint_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browsing_data/browsing_data_remover_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chrome_browser_main_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/display/display_preferences_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/user_manager_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/power/session_length_limiter_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/proxy_config_service_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/settings/device_settings_cache_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/content_settings/content_settings_default_provider_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/app_notify_channel_setup_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/metrics/metrics_log_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/metrics/variations/resource_request_allowed_notifier_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/metrics/variations/variations_service_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/net/connection_tester_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/http_server_properties_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/pref_proxy_config_tracker_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/notifications/desktop_notifications_unittest.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/notifications/desktop_notifications_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/page_cycler/page_cycler_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/policy/auto_enrollment_client_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/cloud_policy_core_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/device_cloud_policy_manager_chromeos_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/policy/device_status_collector_browsertest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/policy/policy_statistics_collector_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/policy/url_blacklist_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/user_cloud_policy_manager_chromeos_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/prefs/pref_notifier_impl_unittest.cc View 1 chunk +0 lines, -227 lines 0 comments Download
D chrome/browser/prefs/pref_service_unittest.cc View 1 chunk +0 lines, -316 lines 0 comments Download
M chrome/browser/printing/cloud_print/cloud_print_proxy_service_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/profiles/profile_info_cache_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/signin/signin_manager_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/signin/signin_names_io_thread_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/tab_contents/tab_contents_iterator_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/toolbar/action_box_menu_model_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 4 chunks +1 line, -10 lines 0 comments Download
M chrome/test/base/scoped_testing_local_state.h View 1 chunk +1 line, -1 line 0 comments Download
D chrome/test/base/testing_pref_service.h View 1 chunk +0 lines, -196 lines 0 comments Download
D chrome/test/base/testing_pref_service.cc View 1 chunk +0 lines, -56 lines 0 comments Download
M chrome/test/base/testing_pref_service_syncable.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Jói
Hi Mattias, Real changes are isolated to the A+ files and the .gyp(i) files. The ...
7 years, 10 months ago (2013-02-13 14:13:53 UTC) #1
Mattias Nissler (ping if slow)
Nice! LGTM.
7 years, 10 months ago (2013-02-13 14:48:22 UTC) #2
Jói
TBR=ben@chromium.org for #include updates.
7 years, 10 months ago (2013-02-13 14:52:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joi@chromium.org/12253004/11001
7 years, 10 months ago (2013-02-14 11:05:26 UTC) #4
commit-bot: I haz the power
7 years, 10 months ago (2013-02-14 17:20:22 UTC) #5
Message was sent while issue was closed. 
Change committed as 182485

Powered by Google App Engine
This is Rietveld 408576698