presubmit_canned_checks.py - Issue 12252067: Presubmit tests: allow 200 columns in .mk files.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: presubmit_canned_checks.py

Issue 12252067: Presubmit tests: allow 200 columns in .mk files. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master

Patch Set: Add comment Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: presubmit_canned_checks.py

diff --git a/presubmit_canned_checks.py b/presubmit_canned_checks.py

index 5516ca3aae5a5596bfd102a6416d0be1fe47a38a..995aa45504c0ac1f1382d3cd98ee5b2812e125c1 100644

--- a/presubmit_canned_checks.py

+++ b/presubmit_canned_checks.py

@@ -318,6 +318,8 @@ def CheckLongLines(input_api, output_api, maxlen=80, source_file_filter=None):

"""

maxlens = {

'java': 100,

+ # This is specifically for Android's handwritten makefiles (Android.mk).

+ 'mk': 200,

'': maxlen,

}

# Note: these are C++ specific but processed on all languages. :(

« no previous file with comments | « no previous file | tests/presubmit_unittest.py » ('j') | no next file with comments »