Issue 12252067: Presubmit tests: allow 200 columns in .mk files.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12252067: Presubmit tests: allow 200 columns in .mk files. (Closed)

Created:
7 years, 10 months ago by Torne

Modified:
7 years, 10 months ago

Reviewers:
M-A Ruel

CC:
chromium-reviews, Dirk Pranke, cmp+cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master

Visibility:
Public.

More Reviews

Description

Presubmit tests: allow 200 columns in .mk files. The Android WebView code includes several manually-maintained .mk files that are included by the Android build system. These contain some fairly long lines as they need to refer to deep pathnames, which means the CQ cannot be used as it always triggers a presubmit warning. Allow .mk files to have 200 columns per line instead, which should be enough for the long paths that are used. Add a test case for this. BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=182733

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add comment #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -0 lines)			Patch
	M	presubmit_canned_checks.py	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
	M	tests/presubmit_unittest.py	View		1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Torne

Does this seem reasonable? We keep being unable to use the CQ for CLs that ...

7 years, 10 months ago (2013-02-15 12:33:36 UTC) #1

M-A Ruel

lgtm android being awkward, again. https://codereview.chromium.org/12252067/diff/1/presubmit_canned_checks.py File presubmit_canned_checks.py (right): https://codereview.chromium.org/12252067/diff/1/presubmit_canned_checks.py#newcode321 presubmit_canned_checks.py:321: 'mk': 200, Add a ...

7 years, 10 months ago (2013-02-15 15:47:52 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/torne@chromium.org/12252067/3002

7 years, 10 months ago (2013-02-15 16:32:30 UTC) #3

Message was sent while issue was closed.

Change committed as 182733

Expand Messages | Collapse Messages