Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(859)

Unified Diff: content/browser/renderer_host/media/web_contents_video_capture_device.cc

Issue 12252058: Add a |scope| argument to TRACE_EVENT_INSTANT* and require its presence. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix builds 2 Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/media/web_contents_video_capture_device.cc
diff --git a/content/browser/renderer_host/media/web_contents_video_capture_device.cc b/content/browser/renderer_host/media/web_contents_video_capture_device.cc
index c6cecd721817e0409f3a2df3065dcff67bc385ca..1925e5358b1c1ada92d1bfe327b0702e35c6207f 100644
--- a/content/browser/renderer_host/media/web_contents_video_capture_device.cc
+++ b/content/browser/renderer_host/media/web_contents_video_capture_device.cc
@@ -456,6 +456,7 @@ bool CaptureOracle::ObserveEventAndDecideCapture(
// Step 3: Consider the various reasons not to initiate a capture.
if (should_sample && !output_buffer) {
TRACE_EVENT_INSTANT1("mirroring", "EncodeLimited",
+ TRACE_EVENT_SCOPE_THREAD,
"trigger", event_name);
return false;
} else if (!should_sample && output_buffer) {
@@ -464,6 +465,7 @@ bool CaptureOracle::ObserveEventAndDecideCapture(
// capture rate limit: for example, the content is animating at 60fps but
// we're capturing at 30fps.
TRACE_EVENT_INSTANT1("mirroring", "FpsRateLimited",
+ TRACE_EVENT_SCOPE_THREAD,
"trigger", event_name);
}
return false;
@@ -471,6 +473,7 @@ bool CaptureOracle::ObserveEventAndDecideCapture(
// We decided not to capture, but we wouldn't have been able to if we wanted
// to because no output buffer was available.
TRACE_EVENT_INSTANT1("mirroring", "NearlyEncodeLimited",
+ TRACE_EVENT_SCOPE_THREAD,
"trigger", event_name);
return false;
}
@@ -505,7 +508,8 @@ void CaptureOracle::ReportError() {
void CaptureOracle::InvalidateConsumer() {
base::AutoLock guard(lock_);
- TRACE_EVENT_INSTANT0("mirroring", "InvalidateConsumer");
+ TRACE_EVENT_INSTANT0("mirroring", "InvalidateConsumer",
+ TRACE_EVENT_SCOPE_THREAD);
is_started_ = false;
consumer_ = NULL;
« no previous file with comments | « content/browser/renderer_host/compositor_impl_android.cc ('k') | content/browser/renderer_host/render_widget_host_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698