Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(478)

Issue 12252002: Fix the History.WeeklyVisitCount and History.MonthlyVisitCount data collection. (Closed)

Created:
7 years, 10 months ago by Pam (message me for reviews)
Modified:
7 years, 10 months ago
Reviewers:
sky
CC:
chromium-reviews, browser-components-watch_chromium.org
Visibility:
Public.

Description

Fix the History.WeeklyVisitCount and History.MonthlyVisitCount data collection. The SQL statements weren't actually getting called (no Step()). BUG=175968 TEST=nonzero entries in the histograms Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182277

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M chrome/browser/history/history_database.cc View 2 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Pam (message me for reviews)
Scott -- please review this quick fix. Thanks!
7 years, 10 months ago (2013-02-13 15:01:30 UTC) #1
sky
Ha! LGTM
7 years, 10 months ago (2013-02-13 15:42:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pam@chromium.org/12252002/5002
7 years, 10 months ago (2013-02-13 15:47:06 UTC) #3
commit-bot: I haz the power
7 years, 10 months ago (2013-02-13 19:07:25 UTC) #4
Message was sent while issue was closed.
Change committed as 182277

Powered by Google App Engine
This is Rietveld 408576698