Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 12251003: Fix variations seed being reset on a 304 response. (Closed)

Created:
7 years, 10 months ago by Alexei Svitkine (slow)
Modified:
7 years, 10 months ago
Reviewers:
SteveT
CC:
chromium-reviews, MAD, Ilya Sherman, jar (doing other things)
Visibility:
Public.

Description

Fix variations seed being reset on a 304 response. This was broken by https://chromiumcodereview.appspot.com/12096096, which refactored the code causing a 304 response to no longer resulting in an early return. I'll write a test in a follow-up CL. BUG=175795 TEST=VariationsService logging shows that the seed does not get reset when we get a 304. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182151

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M chrome/browser/metrics/variations/variations_service.cc View 1 2 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Alexei Svitkine (slow)
7 years, 10 months ago (2013-02-12 21:36:06 UTC) #1
Alexei Svitkine (slow)
Now, also added some additional checking to VariationsService::StoreSeedData().
7 years, 10 months ago (2013-02-12 21:47:37 UTC) #2
SteveT
LGTM
7 years, 10 months ago (2013-02-12 21:51:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/12251003/7002
7 years, 10 months ago (2013-02-12 21:57:05 UTC) #4
commit-bot: I haz the power
7 years, 10 months ago (2013-02-13 07:07:01 UTC) #5
Message was sent while issue was closed.
Change committed as 182151

Powered by Google App Engine
This is Rietveld 408576698