Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(557)

Issue 12250028: Re-enable print for instant extended NTP which now supports it. (Closed)

Created:
7 years, 10 months ago by MAD
Modified:
7 years, 10 months ago
Reviewers:
Peter Kasting, kuan
CC:
chromium-reviews
Visibility:
Public.

Description

Re-enable print and reload for instant extended NTP which now supports it properly. BUG=165557, 162318 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182415

Patch Set 1 #

Patch Set 2 : Added back reload too. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -12 lines) Patch
M chrome/browser/ui/browser_commands.cc View 1 4 chunks +2 lines, -12 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
MAD
7 years, 10 months ago (2013-02-13 03:23:49 UTC) #1
kuan
lgtm. thanks for enabling it back.
7 years, 10 months ago (2013-02-13 14:46:43 UTC) #2
MAD
I also brought back reload and so I could clean up a bit more stuff... ...
7 years, 10 months ago (2013-02-13 15:39:28 UTC) #3
kuan
lgtm. thx again :)
7 years, 10 months ago (2013-02-13 16:00:02 UTC) #4
Peter Kasting
OWNERS LGTM, and yeah, I think this sort of thing is OK to TBR
7 years, 10 months ago (2013-02-13 21:32:46 UTC) #5
MAD
OK, thanks... I'll TBR next time... On Wed, Feb 13, 2013 at 4:32 PM, <pkasting@chromium.org> ...
7 years, 10 months ago (2013-02-13 21:36:18 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mad@chromium.org/12250028/4001
7 years, 10 months ago (2013-02-13 21:38:35 UTC) #7
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) browser_tests, nacl_integration http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=98716
7 years, 10 months ago (2013-02-13 23:13:25 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mad@chromium.org/12250028/4001
7 years, 10 months ago (2013-02-14 00:07:28 UTC) #9
commit-bot: I haz the power
7 years, 10 months ago (2013-02-14 08:14:57 UTC) #10
Message was sent while issue was closed.
Change committed as 182415

Powered by Google App Engine
This is Rietveld 408576698