Issue 12250021: Remove OVERRIDE annotations from implementations of WebKit APIs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12250021: Remove OVERRIDE annotations from implementations of WebKit APIs (Closed)

Created:
7 years, 10 months ago by jamesr

Modified:
7 years, 10 months ago

Reviewers:
Nico

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, cc-bugs_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove OVERRIDE annotations from implementations of WebKit APIs I'm refactoring these APIs in the WebKit repo but can't sanely stage changes to the API without breaking these OVERRIDE annotations since the interface and implementations are in separate repositories. The clang plugin knows to not enforce OVERRIDE for APIs in the WebKit namespace so this won't break that. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182149

Patch Set 1 #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -24 lines)			Patch
	M	content/renderer/render_view_impl.h	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	webkit/compositor_bindings/web_layer_tree_view_impl.h	View		1 chunk	+23 lines, -23 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/12250021/1

7 years, 10 months ago (2013-02-12 23:46:14 UTC) #2

Message was sent while issue was closed.

Change committed as 182149

Expand Messages | Collapse Messages