Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 12250019: Removed gfx::QuadF::operator =(const gfx::QuadF&) and let the compiler generate one (Closed)

Created:
7 years, 10 months ago by whunt
Modified:
7 years, 10 months ago
Reviewers:
danakj, shawnsingh
CC:
chromium-reviews, cc-bugs_chromium.org
Visibility:
Public.

Description

Removed gfx::QuadF::operator =(const gfx::QuadF&) and let the compiler generate one This function showed up as hot in the trace and should not have been explicitly implemented as non-inline (pushing the args for the function call costs as much as the copy itself so operator = should *never* not be inlined if it's just doing a normal copy) BUG=175855 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182148

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -8 lines) Patch
M ui/gfx/quad_f.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/gfx/quad_f.cc View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
whunt
7 years, 10 months ago (2013-02-13 00:00:50 UTC) #1
danakj
LGTM
7 years, 10 months ago (2013-02-13 00:03:08 UTC) #2
shawnsingh
I'd be happy with this. Style guide seems to encourage it, too. So let's kill ...
7 years, 10 months ago (2013-02-13 00:04:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/whunt@chromium.org/12250019/1
7 years, 10 months ago (2013-02-13 00:16:19 UTC) #4
commit-bot: I haz the power
7 years, 10 months ago (2013-02-13 06:40:37 UTC) #5
Message was sent while issue was closed.
Change committed as 182148

Powered by Google App Engine
This is Rietveld 408576698