Setting a custom background on a HiDPI display will result in the background only being applied to …

Setting a custom background on a HiDPI display will result in the background only being applied to the top left corner of the view. Scaling the canvas to the device scale factor before applying the clip rect for painting the background fixes the issue.

BUG=175698
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=184100

[jamesr, 2013-02-13 01:43:21]

https://codereview.chromium.org/12249002/diff/1/AUTHORS
File AUTHORS (right):

https://codereview.chromium.org/12249002/diff/1/AUTHORS#newcode224
AUTHORS:224: Horia Olaru <olaru@adobe.com>
Have you signed a CLA? (see
http://dev.chromium.org/developers/contributing-code#TOC-Get-your-code-ready). 
I don't see you in our list, but perhaps I'm looking for the wrong thing

[Horia Olaru, 2013-02-13 02:09:06]

On 2013/02/13 01:43:21, jamesr wrote:
> https://codereview.chromium.org/12249002/diff/1/AUTHORS
> File AUTHORS (right):
> 
> https://codereview.chromium.org/12249002/diff/1/AUTHORS#newcode224
> AUTHORS:224: Horia Olaru <mailto:olaru@adobe.com>
> Have you signed a CLA? (see
> http://dev.chromium.org/developers/contributing-code#TOC-Get-your-code-ready).

> I don't see you in our list, but perhaps I'm looking for the wrong thing

I should be listed in some internal list for Adobe. I just found the email sent
to dannyb that had my name in it. My full name was listed there:
Horia-Iosif Olaru <olaru@adobe.com>

Should I add the same here?

[jamesr, 2013-02-13 02:12:03]

On 2013/02/13 02:09:06, Horia Olaru wrote:
> On 2013/02/13 01:43:21, jamesr wrote:
> > https://codereview.chromium.org/12249002/diff/1/AUTHORS
> > File AUTHORS (right):
> > 
> > https://codereview.chromium.org/12249002/diff/1/AUTHORS#newcode224
> > AUTHORS:224: Horia Olaru <mailto:olaru@adobe.com>
> > Have you signed a CLA? (see
> >
http://dev.chromium.org/developers/contributing-code#TOC-Get-your-code-ready).
> 
> > I don't see you in our list, but perhaps I'm looking for the wrong thing
> 
> I should be listed in some internal list for Adobe. I just found the email
sent
> to dannyb that had my name in it. My full name was listed there:
> Horia-Iosif Olaru <mailto:olaru@adobe.com>
> 
> Should I add the same here?

Aha!  Turns out I was looking in the wrong place, you're there.  I think having
the name you prefer to use in AUTHORS is OK.

I also think thakis@ should review this, so over to Nico!

[Nico, 2013-02-13 22:56:44]

https://codereview.chromium.org/12249002/diff/1/content/renderer/render_widge...
File content/renderer/render_widget.cc (right):

https://codereview.chromium.org/12249002/diff/1/content/renderer/render_widge...
content/renderer/render_widget.cc:1805: void RenderWidget::SetBackground(const
SkBitmap& background) {
Is this function even still used? I think it was used by extensions way back
when we still had an extension bar (which never launched) – can we just kill
this?

[Horia Olaru, 2013-02-13 23:41:21]

https://codereview.chromium.org/12249002/diff/1/content/renderer/render_widge...
File content/renderer/render_widget.cc (right):

https://codereview.chromium.org/12249002/diff/1/content/renderer/render_widge...
content/renderer/render_widget.cc:1805: void RenderWidget::SetBackground(const
SkBitmap& background) {
On 2013/02/13 22:56:44, Nico wrote:
> Is this function even still used? I think it was used by extensions way back
> when we still had an extension bar (which never launched) – can we just
kill
> this?

I am not familiar with the history, but a quick search shows the following files
using it.
chrome/browser/chromeos/login/webui_login_view.cc
chrome/browser/ui/cocoa/extensions/extension_view_mac.mm
chrome/browser/ui/gtk/extensions/extension_view_gtk.cc
chrome/browser/ui/views/extensions/extension_view_views.cc
chrome/browser/ui/views/extensions/native_app_window_views.cc. 

To be fair, I am not familiar with them, so I couldn't say whether you could do
without the code that uses SetBackground or not.

We are implementing an offscreen render view, and we use this function to make
the view transparent (by setting a 1x1 px transparent background for the
widget). The above files use in much the same way. Otherwise, even if the html
is transparent, it is painted on top of a white (non-transparent) background.

[Horia Olaru, 2013-02-18 16:22:08]

Friendly poke.

[Nico, 2013-02-21 18:55:11]

This makes sense to me, lgtm. Feel free to hit the commit queue checkbox.

(+jeremya because he uses this function for apps. I think this should do the
right thing for apps too.)

[commit-bot: I haz the power, 2013-02-21 18:57:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/olaru@adobe.com/12249002/1

[commit-bot: I haz the power, 2013-02-21 18:57:32]

Failed to apply patch for AUTHORS:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file AUTHORS
  Hunk #1 FAILED at 221.
  1 out of 1 hunk FAILED -- saving rejects to file AUTHORS.rej

Patch:       AUTHORS
Index: AUTHORS
diff --git a/AUTHORS b/AUTHORS
index
04eb2b68d7179a1eec074176e5844e147dbff9b7..ad892743de2f105479586cf57fc11522c8557a98
100644
--- a/AUTHORS
+++ b/AUTHORS
@@ -221,3 +221,5 @@ Ion Rosca <rosca@adobe.com>
 Sylvain Zimmer <sylvinus@gmail.com>
 Sungmann Cho <sungmann.cho@gmail.com>
 方觉 (Fang Jue) <fangjue23303@gmail.com>
+Horia Olaru <olaru@adobe.com>
+Horia Olaru <horia.olaru@gmail.com>

[commit-bot: I haz the power, 2013-02-21 19:09:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/olaru@adobe.com/12249002/18001

[commit-bot: I haz the power, 2013-02-21 19:09:58]

Presubmit check for 12249002-18001 failed and returned exit status 1.

INFO:root:Found 2 file(s).

Running presubmit commit checks ...
Running /b/commit-queue/workdir/chromium/PRESUBMIT.py

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    content/renderer

[Nico, 2013-02-21 19:14:18]

jamesr: Can you OWNERS-stamp, please?

[jamesr, 2013-02-21 19:16:09]

On 2013/02/21 19:14:18, Nico wrote:
> jamesr: Can you OWNERS-stamp, please?

lgtm

[commit-bot: I haz the power, 2013-02-21 20:09:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/olaru@adobe.com/12249002/18001

[commit-bot: I haz the power, 2013-02-21 22:09:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/olaru@adobe.com/12249002/18001

[jeremya, 2013-02-21 22:19:29]

https://codereview.chromium.org/12249002/diff/1/content/renderer/render_widge...
File content/renderer/render_widget.cc (right):

https://codereview.chromium.org/12249002/diff/1/content/renderer/render_widge...
content/renderer/render_widget.cc:1805: void RenderWidget::SetBackground(const
SkBitmap& background) {
This is used to build transparent Chrome Apps on CrOS (see
http://crrev.com/175700 in native_app_window_views.cc)

[commit-bot: I haz the power, 2013-02-22 12:22:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/olaru@adobe.com/12249002/18001

[commit-bot: I haz the power, 2013-02-22 13:37:46]

Change committed as 184100