ui/views/controls/textfield/native_textfield_views.cc - Issue 12238002: Views Textfield: Copy on Ctrl+Insert, fix and disable overtype.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/controls/textfield/native_textfield_views.cc

Issue 12238002: Views Textfield: Copy on Ctrl+Insert, fix and disable overtype. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Expand unit tests. Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/views/controls/textfield/native_textfield_views.cc

diff --git a/ui/views/controls/textfield/native_textfield_views.cc b/ui/views/controls/textfield/native_textfield_views.cc

index c8cfb993c18da65c38b5abf7e4f36e4c23cd200c..8318671d454fd77df1aa233e7526a81877753472 100644

--- a/ui/views/controls/textfield/native_textfield_views.cc

+++ b/ui/views/controls/textfield/native_textfield_views.cc

@@ -1085,8 +1085,10 @@ bool NativeTextfieldViews::HandleKeyEvent(const ui::KeyEvent& key_event) {

text_changed = true;

break;

case ui::VKEY_INSERT:

- GetRenderText()->ToggleInsertMode();

- cursor_changed = true;

+ if (control && !shift)

+ Copy();

+ else if (shift && !control)

+ cursor_changed = text_changed = Paste();

break;

default:

break;