Views Textfield: Copy on Ctrl+Insert, fix and disable overtype.

ui/gfx/render_text.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/gfx/render_text.h"
 
 #include <algorithm>
 
 #include "base/i18n/break_iterator.h"
 #include "base/logging.h"
@@ skipping 752 matching lines @@
 
   // Apply an underline to the composition range in |underlines|.
   if (composition_range_.IsValid() && !composition_range_.is_empty())
     styles_[UNDERLINE].ApplyValue(true, composition_range_);
 
   // Apply the selected text color to the [un-reversed] selection range.
   if (!selection().is_empty()) {
     const ui::Range range(selection().GetMin(), selection().GetMax());
     colors_.ApplyValue(selection_color_, range);
   }
-  // Apply the selected text color to the cursor range in overtype mode.
-  if (!insert_mode_ && cursor_visible() && focused()) {
-    const size_t cursor = cursor_position();
-    const size_t next = IndexOfAdjacentGrapheme(cursor, CURSOR_FORWARD);
-    colors_.ApplyValue(selection_color_, ui::Range(cursor, next));
-  }
   composition_and_selection_styles_applied_ = true;
 }
 
 void RenderText::UndoCompositionAndSelectionStyles() {
   // Restore the underline and color breaks to undo the temporary styles.
   DCHECK(composition_and_selection_styles_applied_);
   colors_ = saved_colors_;
   styles_[UNDERLINE] = saved_underlines_;
   composition_and_selection_styles_applied_ = false;
 }
@@ skipping 166 matching lines @@
                                     selection_background_unfocused_color_;
   const std::vector<Rect> sel = GetSubstringBounds(selection());
   for (std::vector<Rect>::const_iterator i = sel.begin(); i < sel.end(); ++i)
     canvas->FillRect(*i, color);
 }
 
 void RenderText::DrawCursor(Canvas* canvas) {
   // Paint cursor. Replace cursor is drawn as rectangle for now.
   // TODO(msw): Draw a better cursor with a better indication of association.
   if (cursor_enabled() && cursor_visible() && focused()) {
-    const Rect& bounds = GetUpdatedCursorBounds();
-    DCHECK(bounds.width());
-    canvas->FillRect(bounds, cursor_color_);
+    canvas->FillRect(GetUpdatedCursorBounds(),
+        insert_mode_ ? cursor_color_ : selection_background_unfocused_color_);
   }
 }
 
 }  // namespace gfx