Issue 12237003: Renaming the CdmWrapper build targets.

Issue 12237003: Renaming the CdmWrapper build targets. (Closed)

Created:
7 years, 10 months ago by dkovalev

Modified:
7 years, 10 months ago

Reviewers:
brettw, xhwang

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, feature-media-reviews_chromium.org, Tom Finegan

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Renaming the CdmWrapper build targets. TEST=CDM builds on all supported platforms. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181247

Patch Set 2 : Wording change #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -15 lines)			Patch
M	build/all.gyp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/chrome_dll_bundle.gypi	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/chrome_exe.gypi	View		1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/media/encrypted_media_browsertest.cc	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	content/content_tests.gypi	View		1 chunk	+1 line, -1 line	0 comments	Download
M	third_party/widevine/cdm/widevine_cdm.gyp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	third_party/widevine/cdm/widevine_cdm_common.h	View	1	1 chunk	+4 lines, -5 lines	0 comments	Download
M	webkit/media/webkit_media.gypi	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

xhwang

lgtm https://codereview.chromium.org/12237003/diff/1/webkit/media/webkit_media.gypi File webkit/media/webkit_media.gypi (right): https://codereview.chromium.org/12237003/diff/1/webkit/media/webkit_media.gypi#newcode223 webkit/media/webkit_media.gypi:223: 'product_extension': 'plugin', this is a system requirement to ...

7 years, 10 months ago (2013-02-06 03:05:49 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dkovalev@chromium.org/12237003/3014

7 years, 10 months ago (2013-02-06 18:43:29 UTC) #2

commit-bot: I haz the power

Presubmit check for 12237003-3014 failed and returned exit status 1. Running presubmit commit checks ...

7 years, 10 months ago (2013-02-06 18:43:35 UTC) #3

dkovalev

brettw, please do the owners review for files in chrome and content dirs

7 years, 10 months ago (2013-02-06 22:32:16 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dkovalev@chromium.org/12237003/3014

7 years, 10 months ago (2013-02-07 05:21:50 UTC) #6

Message was sent while issue was closed.

Change committed as 181247

Expand Messages | Collapse Messages