Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1022)

Unified Diff: chrome/browser/extensions/api/media_galleries/media_galleries_api.cc

Issue 12236005: Media Galleries: Disable write support. (try 2) (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/extensions/api/media_galleries/media_galleries_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/api/media_galleries/media_galleries_api.cc
===================================================================
--- chrome/browser/extensions/api/media_galleries/media_galleries_api.cc (revision 181939)
+++ chrome/browser/extensions/api/media_galleries/media_galleries_api.cc (working copy)
@@ -143,10 +143,6 @@
MediaGalleriesPermission::kReadPermission);
bool has_read_permission = GetExtension()->CheckAPIPermissionWithParam(
APIPermission::kMediaGalleries, &read_param);
- MediaGalleriesPermission::CheckParam write_param(
- MediaGalleriesPermission::kWritePermission);
- bool has_write_permission = GetExtension()->CheckAPIPermissionWithParam(
- APIPermission::kMediaGalleries, &write_param);
const int child_id = rvh->GetProcess()->GetID();
std::set<std::string> file_system_names;
@@ -185,16 +181,12 @@
if (filesystems[i].path.empty())
continue;
- if (has_read_permission || has_write_permission) {
+ if (has_read_permission) {
content::ChildProcessSecurityPolicy* policy =
ChildProcessSecurityPolicy::GetInstance();
if (!policy->CanReadFile(child_id, filesystems[i].path))
policy->GrantReadFile(child_id, filesystems[i].path);
policy->GrantReadFileSystem(child_id, filesystems[i].fsid);
- if (has_write_permission) {
- policy->GrantWriteFileSystem(child_id, filesystems[i].fsid);
- policy->GrantCreateFileForFileSystem(child_id, filesystems[i].fsid);
- }
}
}
« no previous file with comments | « no previous file | chrome/browser/extensions/api/media_galleries/media_galleries_apitest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698