Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: chrome/common/extensions/permissions/media_galleries_permission_unittest.cc

Issue 12236005: Media Galleries: Disable write support. (try 2) (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/common/extensions/permissions/media_galleries_permission_data.cc ('k') | chrome/common/extensions/permissions/permission_set_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // These tests make sure MediaGalleriesPermission values are parsed correctly. 5 // These tests make sure MediaGalleriesPermission values are parsed correctly.
6 6
7 #include "base/values.h" 7 #include "base/values.h"
8 #include "chrome/common/extensions/permissions/media_galleries_permission.h" 8 #include "chrome/common/extensions/permissions/media_galleries_permission.h"
9 #include "chrome/common/extensions/permissions/media_galleries_permission_data.h " 9 #include "chrome/common/extensions/permissions/media_galleries_permission_data.h "
10 #include "chrome/common/extensions/permissions/permissions_info.h" 10 #include "chrome/common/extensions/permissions/permissions_info.h"
(...skipping 15 matching lines...) Expand all
26 26
27 scoped_ptr<APIPermission> permission( 27 scoped_ptr<APIPermission> permission(
28 permission_info->CreateAPIPermission()); 28 permission_info->CreateAPIPermission());
29 29
30 // access_type + all_detected 30 // access_type + all_detected
31 scoped_ptr<base::ListValue> value(new base::ListValue()); 31 scoped_ptr<base::ListValue> value(new base::ListValue());
32 value->AppendString(MediaGalleriesPermission::kAllAutoDetectedPermission); 32 value->AppendString(MediaGalleriesPermission::kAllAutoDetectedPermission);
33 value->AppendString(MediaGalleriesPermission::kReadPermission); 33 value->AppendString(MediaGalleriesPermission::kReadPermission);
34 EXPECT_TRUE(permission->FromValue(value.get())); 34 EXPECT_TRUE(permission->FromValue(value.get()));
35 35
36 value.reset(new base::ListValue());
37 value->AppendString(MediaGalleriesPermission::kAllAutoDetectedPermission);
38 value->AppendString(MediaGalleriesPermission::kWritePermission);
39 EXPECT_TRUE(permission->FromValue(value.get()));
40
41 // all_detected 36 // all_detected
42 value.reset(new base::ListValue()); 37 value.reset(new base::ListValue());
43 value->AppendString(MediaGalleriesPermission::kAllAutoDetectedPermission); 38 value->AppendString(MediaGalleriesPermission::kAllAutoDetectedPermission);
44 EXPECT_TRUE(permission->FromValue(value.get())); 39 EXPECT_TRUE(permission->FromValue(value.get()));
45 40
46 // access_type 41 // access_type
47 value.reset(new base::ListValue()); 42 value.reset(new base::ListValue());
48 value->AppendString(MediaGalleriesPermission::kReadPermission); 43 value->AppendString(MediaGalleriesPermission::kReadPermission);
49 EXPECT_TRUE(permission->FromValue(value.get())); 44 EXPECT_TRUE(permission->FromValue(value.get()));
50 45
51 value.reset(new base::ListValue());
52 value->AppendString(MediaGalleriesPermission::kWritePermission);
53 EXPECT_TRUE(permission->FromValue(value.get()));
54
55 // Repeats are ok. 46 // Repeats are ok.
56 value.reset(new base::ListValue()); 47 value.reset(new base::ListValue());
57 value->AppendString(MediaGalleriesPermission::kAllAutoDetectedPermission); 48 value->AppendString(MediaGalleriesPermission::kAllAutoDetectedPermission);
58 value->AppendString(MediaGalleriesPermission::kAllAutoDetectedPermission); 49 value->AppendString(MediaGalleriesPermission::kAllAutoDetectedPermission);
59 EXPECT_TRUE(permission->FromValue(value.get())); 50 EXPECT_TRUE(permission->FromValue(value.get()));
60
61 value.reset(new base::ListValue());
62 value->AppendString(MediaGalleriesPermission::kWritePermission);
63 value->AppendString(MediaGalleriesPermission::kWritePermission);
64 EXPECT_TRUE(permission->FromValue(value.get()));
65
66 value.reset(new base::ListValue());
67 value->AppendString(MediaGalleriesPermission::kAllAutoDetectedPermission);
68 value->AppendString(MediaGalleriesPermission::kAllAutoDetectedPermission);
69 value->AppendString(MediaGalleriesPermission::kWritePermission);
70 EXPECT_TRUE(permission->FromValue(value.get()));
71 } 51 }
72 52
73 TEST(MediaGalleriesPermissionTest, BadValues) { 53 TEST(MediaGalleriesPermissionTest, BadValues) {
74 const APIPermissionInfo* permission_info = 54 const APIPermissionInfo* permission_info =
75 PermissionsInfo::GetInstance()->GetByID(APIPermission::kMediaGalleries); 55 PermissionsInfo::GetInstance()->GetByID(APIPermission::kMediaGalleries);
76 56
77 scoped_ptr<APIPermission> permission( 57 scoped_ptr<APIPermission> permission(
78 permission_info->CreateAPIPermission()); 58 permission_info->CreateAPIPermission());
79 59
80 // Empty 60 // Empty
81 scoped_ptr<base::ListValue> value(new base::ListValue()); 61 scoped_ptr<base::ListValue> value(new base::ListValue());
82 EXPECT_FALSE(permission->FromValue(value.get())); 62 EXPECT_FALSE(permission->FromValue(value.get()));
83
84 // Read and write.
85 value.reset(new base::ListValue());
86 value->AppendString(MediaGalleriesPermission::kReadPermission);
87 value->AppendString(MediaGalleriesPermission::kWritePermission);
88 EXPECT_FALSE(permission->FromValue(value.get()));
89
90 value.reset(new base::ListValue());
91 value->AppendString(MediaGalleriesPermission::kAllAutoDetectedPermission);
92 value->AppendString(MediaGalleriesPermission::kReadPermission);
93 value->AppendString(MediaGalleriesPermission::kWritePermission);
94 EXPECT_FALSE(permission->FromValue(value.get()));
95 } 63 }
96 64
97 TEST(MediaGalleriesPermissionTest, Equal) { 65 TEST(MediaGalleriesPermissionTest, Equal) {
98 const APIPermissionInfo* permission_info = 66 const APIPermissionInfo* permission_info =
99 PermissionsInfo::GetInstance()->GetByID(APIPermission::kMediaGalleries); 67 PermissionsInfo::GetInstance()->GetByID(APIPermission::kMediaGalleries);
100 68
101 scoped_ptr<APIPermission> permission1( 69 scoped_ptr<APIPermission> permission1(
102 permission_info->CreateAPIPermission()); 70 permission_info->CreateAPIPermission());
103 scoped_ptr<APIPermission> permission2( 71 scoped_ptr<APIPermission> permission2(
104 permission_info->CreateAPIPermission()); 72 permission_info->CreateAPIPermission());
(...skipping 28 matching lines...) Expand all
133 101
134 scoped_ptr<base::ListValue> value(new base::ListValue()); 102 scoped_ptr<base::ListValue> value(new base::ListValue());
135 value->AppendString(MediaGalleriesPermission::kAllAutoDetectedPermission); 103 value->AppendString(MediaGalleriesPermission::kAllAutoDetectedPermission);
136 value->AppendString(MediaGalleriesPermission::kReadPermission); 104 value->AppendString(MediaGalleriesPermission::kReadPermission);
137 ASSERT_TRUE(permission1->FromValue(value.get())); 105 ASSERT_TRUE(permission1->FromValue(value.get()));
138 106
139 scoped_ptr<base::Value> vtmp(permission1->ToValue()); 107 scoped_ptr<base::Value> vtmp(permission1->ToValue());
140 ASSERT_TRUE(vtmp); 108 ASSERT_TRUE(vtmp);
141 ASSERT_TRUE(permission2->FromValue(vtmp.get())); 109 ASSERT_TRUE(permission2->FromValue(vtmp.get()));
142 EXPECT_TRUE(permission1->Equal(permission2.get())); 110 EXPECT_TRUE(permission1->Equal(permission2.get()));
143
144 value.reset(new base::ListValue());
145 value->AppendString(MediaGalleriesPermission::kWritePermission);
146 ASSERT_TRUE(permission1->FromValue(value.get()));
147
148 vtmp = permission1->ToValue();
149 ASSERT_TRUE(vtmp);
150 ASSERT_TRUE(permission2->FromValue(vtmp.get()));
151 EXPECT_TRUE(permission1->Equal(permission2.get()));
152 } 111 }
153 112
154 } // namespace 113 } // namespace
155 114
156 } // namespace extensions 115 } // namespace extensions
OLDNEW
« no previous file with comments | « chrome/common/extensions/permissions/media_galleries_permission_data.cc ('k') | chrome/common/extensions/permissions/permission_set_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698