Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1223213002: Remove libs/clock in favor of luci-go/common/clock. (Closed)

Created:
5 years, 5 months ago by iannucci
Modified:
5 years, 5 months ago
Reviewers:
dnj, seanmccullough
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/infra/infra.git@abstract
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

Remove libs/clock in favor of luci-go/common/clock. The new one is a ported version of the old one :) R=dnj@chromium.org,seanmccullough@chromium.org BUG= Committed: https://chromium.googlesource.com/infra/infra/+/9bf87b709a5de3c32d8e61cf2bc42529494ca19a

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -955 lines) Patch
D go/src/infra/libs/clock/clock.go View 1 chunk +0 lines, -21 lines 0 comments Download
D go/src/infra/libs/clock/clock.infra_testing View 1 chunk +0 lines, -4 lines 0 comments Download
D go/src/infra/libs/clock/clockflag/duration.go View 1 chunk +0 lines, -61 lines 0 comments Download
D go/src/infra/libs/clock/clockflag/duration_test.go View 1 chunk +0 lines, -64 lines 0 comments Download
D go/src/infra/libs/clock/clockflag/time.go View 1 chunk +0 lines, -59 lines 0 comments Download
D go/src/infra/libs/clock/clockflag/time_test.go View 1 chunk +0 lines, -62 lines 0 comments Download
D go/src/infra/libs/clock/context.go View 1 chunk +0 lines, -71 lines 0 comments Download
D go/src/infra/libs/clock/systemclock.go View 1 chunk +0 lines, -39 lines 0 comments Download
D go/src/infra/libs/clock/systemtimer.go View 1 chunk +0 lines, -38 lines 0 comments Download
D go/src/infra/libs/clock/systemtimer_test.go View 1 chunk +0 lines, -65 lines 0 comments Download
D go/src/infra/libs/clock/testclock/context.go View 1 chunk +0 lines, -20 lines 0 comments Download
D go/src/infra/libs/clock/testclock/testclock.go View 1 chunk +0 lines, -178 lines 0 comments Download
D go/src/infra/libs/clock/testclock/testclock.infra_testing View 1 chunk +0 lines, -4 lines 0 comments Download
D go/src/infra/libs/clock/testclock/testclock_test.go View 1 chunk +0 lines, -57 lines 0 comments Download
D go/src/infra/libs/clock/testclock/testtimer.go View 1 chunk +0 lines, -77 lines 0 comments Download
D go/src/infra/libs/clock/testclock/testtimer_test.go View 1 chunk +0 lines, -116 lines 0 comments Download
D go/src/infra/libs/clock/timer.go View 1 chunk +0 lines, -16 lines 0 comments Download
M go/src/infra/monitoring/dispatcher/dispatcher.go View 1 1 chunk +1 line, -1 line 0 comments Download
M go/src/infra/monitoring/dispatcher/loop_test.go View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
iannucci
oops! forgot to publish this one. Should be short though :)
5 years, 5 months ago (2015-07-14 01:35:07 UTC) #1
seanmccullough
lgtm
5 years, 5 months ago (2015-07-14 01:48:02 UTC) #2
dnj
lgtm
5 years, 5 months ago (2015-07-14 02:32:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1223213002/20001
5 years, 5 months ago (2015-07-14 05:18:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1223213002/40001
5 years, 5 months ago (2015-07-14 17:07:18 UTC) #9
commit-bot: I haz the power
5 years, 5 months ago (2015-07-14 17:09:52 UTC) #10
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/infra/infra/+/9bf87b709a5de3c32d8e61cf2bc42...

Powered by Google App Engine
This is Rietveld 408576698