chrome/test/chromedriver/navigation_tracker.cc - Issue 12230021: [chromedriver] Send all OnConnected before any OnEvent when connected.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/chromedriver/navigation_tracker.cc

Issue 12230021: [chromedriver] Send all OnConnected before any OnEvent when connected. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address comments. Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/test/chromedriver/navigation_tracker.cc

diff --git a/chrome/test/chromedriver/navigation_tracker.cc b/chrome/test/chromedriver/navigation_tracker.cc

index 0d26474f4af3805bfebb8b090bf6fccc9ebe1468..bdc1352eed7b20d6ebddf9d5da7b8ed581897299 100644

--- a/chrome/test/chromedriver/navigation_tracker.cc

+++ b/chrome/test/chromedriver/navigation_tracker.cc

@@ -22,6 +22,7 @@ bool NavigationTracker::IsPendingNavigation(const std::string& frame_id) {

}

Status NavigationTracker::OnConnected() {

+ frame_state_.clear();

// Enable page domain notifications to allow tracking navigation state.

base::DictionaryValue params;

return client_->SendCommand("Page.enable", params);

« no previous file with comments | « chrome/test/chromedriver/frame_tracker.cc ('k') | no next file » | no next file with comments »