Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6232)

Unified Diff: chrome/test/chromedriver/devtools_client_impl.h

Issue 12230021: [chromedriver] Send all OnConnected before any OnEvent when connected. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address comments. Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/test/chromedriver/devtools_client_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/chromedriver/devtools_client_impl.h
diff --git a/chrome/test/chromedriver/devtools_client_impl.h b/chrome/test/chromedriver/devtools_client_impl.h
index 4d03e78f2e7225fef3358c4936d081403ad9c0b5..c496c0f30714b1737a08376685e261ee4661dbaa 100644
--- a/chrome/test/chromedriver/devtools_client_impl.h
+++ b/chrome/test/chromedriver/devtools_client_impl.h
@@ -92,12 +92,14 @@ class DevToolsClientImpl : public DevToolsClient {
internal::InspectorMessageType* type,
internal::InspectorEvent* event,
internal::InspectorCommandResponse* response);
- virtual Status NotifyEventListeners(const std::string& method,
- const base::DictionaryValue& params);
+ bool HasReceivedCommandResponse(int cmd_id);
+ Status NotifyEventListeners(const std::string& method,
+ const base::DictionaryValue& params);
scoped_ptr<SyncWebSocket> socket_;
GURL url_;
ParserFunc parser_func_;
std::list<DevToolsEventListener*> listeners_;
+ std::list<DevToolsEventListener*> listeners_for_on_connected_;
typedef std::map<int, base::DictionaryValue*> ResponseMap;
ResponseMap cmd_response_map_;
bool connected_;
« no previous file with comments | « no previous file | chrome/test/chromedriver/devtools_client_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698