Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 12230017: Declarative WR: Enable and measure request blocking until registries are loaded. (Closed)

Created:
7 years, 10 months ago by vabr (Chromium)
Modified:
7 years, 10 months ago
Reviewers:
Matt Perry, battre
CC:
chromium-reviews, Aaron Boodman, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Declarative WR: Enable and measure request blocking until registries are loaded. Make requests wait until relevant rule registries are loaded. Log the delay with UMA as Extensions.NetworkDelayRegistryLoad. BUG=175961 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=183467

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M chrome/browser/extensions/api/web_request/web_request_api.cc View 3 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
vabr (Chromium)
Hi Dominic, PTAL. Vaclav
7 years, 10 months ago (2013-02-13 17:36:04 UTC) #1
battre
I think this is CL number 2. Number 1 would be to benchmark RulesRegistryStorageDelegate
7 years, 10 months ago (2013-02-14 13:16:48 UTC) #2
Matt Perry
This one LGTM. Seems like you could land the 2 CLs in either order.
7 years, 10 months ago (2013-02-15 21:58:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vabr@chromium.org/12230017/1
7 years, 10 months ago (2013-02-20 09:05:30 UTC) #4
commit-bot: I haz the power
7 years, 10 months ago (2013-02-20 11:15:42 UTC) #5
Message was sent while issue was closed.
Change committed as 183467

Powered by Google App Engine
This is Rietveld 408576698