Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(729)

Issue 12230015: Fix unicode rendering of IDL files in the extension/apps developer server. (Closed)

Created:
7 years, 10 months ago by not at google - send to devlin
Modified:
7 years, 10 months ago
CC:
chromium-reviews, Aaron Boodman, chromium-apps-reviews_chromium.org, cduvall
Visibility:
Public.

Description

Fix unicode rendering of IDL files in the extension/apps developer server. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182346

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5 lines) Patch
M chrome/common/extensions/docs/server2/file_system.py View 1 chunk +1 line, -3 lines 1 comment Download
M chrome/common/extensions/docs/server2/local_file_system.py View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/server2/subversion_file_system.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
not at google - send to devlin
7 years, 10 months ago (2013-02-13 17:11:37 UTC) #1
not at google - send to devlin
https://codereview.chromium.org/12230015/diff/1/chrome/common/extensions/docs/server2/file_system.py File chrome/common/extensions/docs/server2/file_system.py (left): https://codereview.chromium.org/12230015/diff/1/chrome/common/extensions/docs/server2/file_system.py#oldcode19 chrome/common/extensions/docs/server2/file_system.py:19: if os.path.splitext(path)[-1] not in ['.js', '.html', '.json']: IIRC this ...
7 years, 10 months ago (2013-02-13 17:12:55 UTC) #2
cduvall
lgtm
7 years, 10 months ago (2013-02-13 17:45:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kalman@chromium.org/12230015/1
7 years, 10 months ago (2013-02-13 17:46:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kalman@chromium.org/12230015/1
7 years, 10 months ago (2013-02-13 19:38:45 UTC) #5
commit-bot: I haz the power
7 years, 10 months ago (2013-02-14 00:02:05 UTC) #6
Message was sent while issue was closed.
Change committed as 182346

Powered by Google App Engine
This is Rietveld 408576698