Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 12230008: Android: further "user build" perf test automation. (Closed)

Created:
7 years, 10 months ago by bulach
Modified:
7 years, 10 months ago
Reviewers:
Sami
CC:
chromium-reviews, klundberg+watch_chromium.org, frankf+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy+watch_chromium.org
Visibility:
Public.

Description

Android: further "user build" perf test automation. Use "cat /dev/null" rather than "echo". "echo" is not guaranteed to be in the path or the system image. "cat" seems available on the images used by the bots. BUG=175127 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182261

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/android/pylib/android_commands.py View 1 chunk +1 line, -1 line 2 comments Download

Messages

Total messages: 7 (0 generated)
bulach
7 years, 10 months ago (2013-02-13 10:59:58 UTC) #1
Sami
lgtm. https://codereview.chromium.org/12230008/diff/1/build/android/pylib/android_commands.py File build/android/pylib/android_commands.py (right): https://codereview.chromium.org/12230008/diff/1/build/android/pylib/android_commands.py#newcode732 build/android/pylib/android_commands.py:732: return self.RunShellCommand('su -c cat /dev/null') == [''] This ...
7 years, 10 months ago (2013-02-13 11:05:34 UTC) #2
bulach
thanks sami! CQing.. https://codereview.chromium.org/12230008/diff/1/build/android/pylib/android_commands.py File build/android/pylib/android_commands.py (right): https://codereview.chromium.org/12230008/diff/1/build/android/pylib/android_commands.py#newcode732 build/android/pylib/android_commands.py:732: return self.RunShellCommand('su -c cat /dev/null') == ...
7 years, 10 months ago (2013-02-13 11:08:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bulach@chromium.org/12230008/1
7 years, 10 months ago (2013-02-13 11:09:54 UTC) #4
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) aura_unittests, ppapi_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=83923
7 years, 10 months ago (2013-02-13 11:30:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bulach@chromium.org/12230008/1
7 years, 10 months ago (2013-02-13 11:55:54 UTC) #6
commit-bot: I haz the power
7 years, 10 months ago (2013-02-13 18:29:29 UTC) #7
Message was sent while issue was closed.
Change committed as 182261

Powered by Google App Engine
This is Rietveld 408576698