Pass is_anchor_first with SelectionBounds_Params

Pass is_anchor_first with SelectionBounds_Params

We pass the selection bounds as anchor/focus. Sometimes,
we need the start and end instead, and the is_anchor_first
flag allows us to derive start/end from anchor/focus.

On Android, use this flag to set the correct selection handle
positions.

BUG=162468
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181824

[cjhopman, 2013-02-06 00:42:20]

jcivelli: content/browser/android
darin: content/

This change requires:
https://bugs.webkit.org/show_bug.cgi?id=108667

[darin (slow to review), 2013-02-06 05:05:51]

LGTM for non-java parts.

[Jay Civelli, 2013-02-06 06:44:43]

lgtm

[commit-bot: I haz the power, 2013-02-07 03:32:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/cjhopman@chromium.org/12228005/1

[commit-bot: I haz the power, 2013-02-07 03:32:11]

Failed to apply patch for
content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file
content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
  Hunk #1 FAILED at 1993.
  1 out of 1 hunk FAILED -- saving rejects to file
content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java.rej

Patch:      
content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
Index:
content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
diff --git
a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
index
a5b5039861dc873ecf92e07bf59715a168fb59a9..02f8eac09a168de4fb38d082c3249e06903c1c76
100644
---
a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
+++
b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
@@ -1993,20 +1993,26 @@ public class ContentViewCore implements
MotionEventDelegate, NavigationClient {
 
     @SuppressWarnings("unused")
     @CalledByNative
-    private void onSelectionBoundsChanged(Rect startRect, int dir1, Rect
endRect, int dir2) {
-        int x1 = startRect.left;
-        int y1 = startRect.bottom;
-        int x2 = endRect.left;
-        int y2 = endRect.bottom;
+    private void onSelectionBoundsChanged(Rect anchorRect, int anchorDir, Rect
focusRect,
+            int focusDir, boolean isAnchorFirst) {
+        int x1 = anchorRect.left;
+        int y1 = anchorRect.bottom;
+        int x2 = focusRect.left;
+        int y2 = focusRect.bottom;
 
         if (x1 != x2 || y1 != y2) {
             if (mInsertionHandleController != null) {
                 mInsertionHandleController.hide();
             }
-            mStartHandlePoint.setWindow(x1, y1);
-            mEndHandlePoint.setWindow(x2, y2);
+            if (isAnchorFirst) {
+                mStartHandlePoint.setWindow(x1, y1);
+                mEndHandlePoint.setWindow(x2, y2);
+            } else {
+                mStartHandlePoint.setWindow(x2, y2);
+                mEndHandlePoint.setWindow(x1, y1);
+            }
 
-            getSelectionHandleController().onSelectionChanged(dir1, dir2);
+            getSelectionHandleController().onSelectionChanged(anchorDir,
focusDir);
             updateHandleScreenPositions();
             mHasSelection = true;
         } else {

[commit-bot: I haz the power, 2013-02-11 17:59:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/cjhopman@chromium.org/12228005/4001

[commit-bot: I haz the power, 2013-02-11 20:24:53]

Retried try job too often on mac_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2013-02-11 21:03:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/cjhopman@chromium.org/12228005/4001

[commit-bot: I haz the power, 2013-02-12 00:34:54]

Retried try job too often on mac_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2013-02-12 02:09:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/cjhopman@chromium.org/12228005/4001

[commit-bot: I haz the power, 2013-02-12 02:14:31]

Change committed as 181824